Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c2ca78a87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| */ | ||
|
|
||
| #pragma once | ||
| #include <BehaviorTree/Tasks/BTTask_MoveTo.h> |
There was a problem hiding this comment.
Promote AIModule for public BT headers
This new public header includes AIModule's BTTask_MoveTo, while DungeonGenerator.Build.cs still keeps AIModule/GameplayTasks as private dependencies. Any game or plugin module that includes Sample/Task/BTT_DungeonSampleMoveTo.h will not inherit the required AIModule include/link dependency from DungeonGenerator, so consumers can fail to compile; move the dependency to PublicDependencyModuleNames or keep these BT task headers private.
Useful? React with 👍 / 👎.
| if (mMoveTime >= MoveTimeLimit) | ||
| FinishLatentTask(OwnerComp, EBTNodeResult::Aborted); |
There was a problem hiding this comment.
Guard the default move time limit
With MoveTimeLimit defaulting to 0, any task that is not already in the attack-distance band reaches this check after the first tick (DeltaSeconds > 0) and aborts immediately. Sample behavior trees that use the default value, or existing assets that do not override it, will never actually move; treat 0 as disabled or give it a positive default before comparing.
Useful? React with 👍 / 👎.
Changes
Migration policy
DeprecatedPropertyfields in the runtime class layout so v1 assets can be migrated safely to the v2 parameter groups.FDungeonGeneratedRoomInfoandADungeonRoomSensorBase::GetGeneratedRoomInfo()are now the standard v2 API for generated room information. Legacy room-information fields onADungeonRoomSensorBaseremain as deprecated migration fields.ADungeonRoomSensorBaseso helper enemy counts are tuned only by area,GameplayRoleEnemySpawnMultipliers, andStructuralRoleEnemySpawnMultipliers.変更点
移行ポリシー
DeprecatedPropertyフィールドが維持されています。FDungeonGeneratedRoomInfoおよびADungeonRoomSensorBase::GetGeneratedRoomInfo()は、生成された部屋情報に関する v2 の標準 API となりました。ADungeonRoomSensorBase上のレガシーなルーム情報フィールドは、非推奨の移行用フィールドとして残されています。ADungeonRoomSensorBaseから、未公開の v2 ルームフラグによる敵スポーン倍率を削除しました。これにより、ヘルパーの敵数は、エリア、GameplayRoleEnemySpawnMultipliers、およびStructuralRoleEnemySpawnMultipliersによってのみ調整されるようになりました。