feat: add zero/empty guards

Author: jannikluhn

src/common/DKGContract.sol

@@ -13,6 +13,8 @@ contract DKGContract is IDKGContract {
     error MismatchedArrays();
     error AlreadyVoted();
     error WrongDKGContract();
+    error ZeroLengthParameter();
+    error EmptyEonPublicKey();
 
     event DealingSubmitted(
         uint64 indexed keyperSetIndex,
@@ -69,6 +71,9 @@ contract DKGContract is IDKGContract {
         address keyperSetManagerAddress,
         address keyBroadcastContractAddress
     ) {
+        if (phaseLength == 0 || dkgLeadLength == 0) {
+            revert ZeroLengthParameter();
+        }
         PHASE_LENGTH = phaseLength;
         DKG_LEAD_LENGTH = dkgLeadLength;
         _keyperSetManager = KeyperSetManager(keyperSetManagerAddress);
@@ -230,6 +235,9 @@ contract DKGContract is IDKGContract {
         _requirePhase(keyperSetIndex, retryCounter, Phase.Finalizing);
         _checkDKGContract(keyperSetIndex);
         _checkMember(keyperSetIndex, keyperIndex);
+        if (eonPublicKey.length == 0) {
+            revert EmptyEonPublicKey();
+        }
         if (hasVoted[keyperSetIndex][retryCounter][msg.sender]) {
             revert AlreadyVoted();
         }

src/common/ECIESKeyRegistry.sol

@@ -9,6 +9,7 @@ contract ECIESKeyRegistry {
     using EnumerableSet for EnumerableSet.AddressSet;
 
     error NotAMember();
+    error EmptyECIESPublicKey();
 
     event KeyRegistered(address indexed keyper, bytes eciesPublicKey);
 
@@ -35,6 +36,9 @@ contract ECIESKeyRegistry {
         if (keyperSet.getMember(keyperIndex) != msg.sender) {
             revert NotAMember();
         }
+        if (eciesPublicKey.length == 0) {
+            revert EmptyECIESPublicKey();
+        }
         registeredKeypers.add(msg.sender);
         keys[msg.sender] = eciesPublicKey;
         emit KeyRegistered(msg.sender, eciesPublicKey);

test/DKGContract.t.sol

@@ -91,6 +91,26 @@ contract DKGContractTest is Test {
         keyperSetManager.addKeyperSet(ACTIVATION_BLOCK_0, address(keyperSet0));
     }
 
+    function testConstructorRevertsOnZeroPhaseLength() public {
+        vm.expectRevert(DKGContract.ZeroLengthParameter.selector);
+        new DKGContract(
+            0,
+            DKG_LEAD_LENGTH,
+            address(keyperSetManager),
+            address(keyBroadcastContract)
+        );
+    }
+
+    function testConstructorRevertsOnZeroDKGLeadLength() public {
+        vm.expectRevert(DKGContract.ZeroLengthParameter.selector);
+        new DKGContract(
+            PHASE_LENGTH,
+            0,
+            address(keyperSetManager),
+            address(keyBroadcastContract)
+        );
+    }
+
     function testDeploysWithImmutables() public view {
         assertEq(dkgContract.PHASE_LENGTH(), PHASE_LENGTH);
         assertEq(dkgContract.DKG_LEAD_LENGTH(), DKG_LEAD_LENGTH);
@@ -481,6 +501,13 @@ contract DKGContractTest is Test {
         dkgContract.submitSuccessVote(0, 0, 1, EON_KEY_A);
     }
 
+    function testSubmitSuccessVoteRevertsOnEmptyEonPublicKey() public {
+        vm.roll(FINALIZING_BLOCK);
+        vm.prank(keyper0);
+        vm.expectRevert(DKGContract.EmptyEonPublicKey.selector);
+        dkgContract.submitSuccessVote(0, 0, 0, new bytes(0));
+    }
+
     function testSubmitSuccessVoteRevertsOnDoubleVote() public {
         vm.roll(FINALIZING_BLOCK);
         vm.prank(keyper0);

test/ECIESKeyRegistry.t.sol

@@ -144,18 +144,17 @@ contract ECIESKeyRegistryTest is Test {
         registry.registerKey(99, 0, hex"00");
     }
 
-    function testRegisterKeyAcceptsArbitraryBytes() public {
-        // Registry stores arbitrary bytes — no format validation.
+    function testRegisterKeyAcceptsArbitraryNonEmptyBytes() public {
         bytes memory tiny = hex"00";
-        bytes memory empty = new bytes(0);
-
         vm.prank(keyper0);
         registry.registerKey(0, 0, tiny);
         assertEq(registry.getKey(keyper0), tiny);
+    }
 
+    function testRegisterKeyRevertsOnEmptyKey() public {
         vm.prank(keyper0);
-        registry.registerKey(0, 0, empty);
-        assertEq(registry.getKey(keyper0).length, 0);
+        vm.expectRevert(ECIESKeyRegistry.EmptyECIESPublicKey.selector);
+        registry.registerKey(0, 0, new bytes(0));
     }
 
     // -------------------------------------------------------------------------