Update build-pr-cmk.yml

Author: shwstppr

.github/workflows/build-pr-cmk.yml

@@ -32,6 +32,9 @@ jobs:
     runs-on: ubuntu-24.04
     env:
       GITHUB_TOKEN: ""
+    outputs:
+      outcome: ${{ steps.meta.outputs.outcome }}
+      artifact_url: ${{ steps.meta.outputs.artifact_url }}
     steps:
       - name: Checkout PR HEAD
         uses: actions/checkout@v4
@@ -51,7 +54,7 @@ jobs:
 
       - name: Upload zipped dist artifact
         id: upload_artifact
-        if: success()
+        if: ${{ steps.build.outcome == 'success' }}   # gate on build outcome
         uses: actions/upload-artifact@v4
         with:
           name: cmk-binaries.pr${{ github.event.pull_request.number }}
@@ -64,13 +67,14 @@ jobs:
         if: always()
         run: |
           echo "outcome=${{ steps.build.outcome }}" >> $GITHUB_OUTPUT
-          # upload-artifact v4 exposes artifact-url output; echo empty if missing
           echo "artifact_url=${{ steps.upload_artifact.outputs.artifact-url }}" >> $GITHUB_OUTPUT
 
   comment:
+    if: always()                       # run even if build job failed
     needs: build
     permissions:
       contents: read
+      issues: write                    # <-- required for issues.createComment
       pull-requests: write
     runs-on: ubuntu-24.04
     steps:
@@ -79,52 +83,38 @@ jobs:
         with:
           script: |
             const { execSync } = require('child_process');
+
             const issue_number = context.payload.pull_request.number;
             const identifier = "cmk-build-artifact-comment";
-            const outcome = "${{ needs.build.outputs.outcome || steps.build.outcome }}".trim() || "${{ needs.build.outputs.outcome }}";
-            // Prefer job output from previous step:
-            const buildOutcome = "${{ needs.build.outputs.outcome }}";
-            const artifactUrl = "${{ needs.build.outputs.artifact_url }}";
-            const runId = "${{ github.run_id }}";
-            const repo = "${{ github.repository }}";
 
-            // Fallback: use provided build outcome var if needs.* resolution is odd
-            const finalOutcome = buildOutcome || outcome || 'failure';
+            const owner = context.payload.repository.owner.login; // base repo (pull_request_target)
+            const repo  = context.payload.repository.name;
+
+            const buildOutcome = "${{ needs.build.outputs.outcome }}";
+            const artifactUrl  = "${{ needs.build.outputs.artifact_url }}";
+            const runId        = "${{ github.run_id }}";
 
-            let commentBody = `<!-- ${identifier} -->\n`;
+            core.info(`Will comment on ${owner}/${repo}#${issue_number}`);
+            core.info(`Outcome=${buildOutcome || '(empty)'} Artifact=${artifactUrl || '(none)'}`);
 
-            if (finalOutcome === 'success' && artifactUrl) {
+            let body = `<!-- ${identifier} -->\n`;
+            if (buildOutcome === 'success' && artifactUrl) {
               const expiryDate = execSync("date -d '+10 days' '+%B %d, %Y'").toString().trim();
-              commentBody += `✅ Build complete for PR #${issue_number}.\n\n`;
-              commentBody += `🔗 Download the [cmk binaries](${artifactUrl}) (expires on ${expiryDate})`;
+              body += `✅ Build complete for PR #${issue_number}.\n\n`;
+              body += `🔗 Download the [cmk binaries](${artifactUrl}) (expires on ${expiryDate})`;
             } else {
-              commentBody += `❌ Build failed for PR #${issue_number}.\n\n`;
-              commentBody += `See the [workflow run](https://github.com/${repo}/actions/runs/${runId}) for details.`;
+              body += `❌ Build failed for PR #${issue_number}.\n\n`;
+              body += `See the run: https://github.com/${owner}/${repo}/actions/runs/${runId}`;
             }
 
-            const { data: comments } = await github.rest.issues.listComments({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number
-            });
-
-            const existing = comments.find(c =>
-              c.user.login === 'github-actions[bot]' &&
-              c.body.includes(identifier)
-            );
+            const { data: comments } = await github.rest.issues.listComments({ owner, repo, issue_number });
+            const existing = comments.find(c => c.user.login === 'github-actions[bot]' && c.body.includes(identifier));
 
             if (existing) {
-              await github.rest.issues.updateComment({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                comment_id: existing.id,
-                body: commentBody
-              });
+              core.info(`Updating comment id ${existing.id}`);
+              await github.rest.issues.updateComment({ owner, repo, comment_id: existing.id, body });
             } else {
-              await github.rest.issues.createComment({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                issue_number,
-                body: commentBody
-              });
+              core.info(`Creating new comment`);
+              await github.rest.issues.createComment({ owner, repo, issue_number, body });
             }
+