adress copilot comments

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Author: shwstppr

services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/UploadManagerImpl.java

@@ -383,7 +383,7 @@ protected void deleteEntitySymlinkRootDirectoryIfNeeded(DeleteEntityDownloadURLC
             return;
         }
         logger.info("Deleting symlink root directory: {} for {}", rootDir, cmd.getExtractUrl());
-        Path rootDirPath = Path.of(BASE_EXTRACT_PATH + rootDir);
+        Path rootDirPath = Path.of(BASE_EXTRACT_PATH, rootDir);
         String failMsg = "Failed to delete symlink root directory: {} for {}";
         try {
             if (!FileUtil.deleteRecursively(rootDirPath)) {

services/secondary-storage/server/src/test/java/org/apache/cloudstack/storage/template/UploadManagerImplTest.java

@@ -75,4 +75,11 @@ public void deletesSymlinkRootDirectoryWhenValidUuid() {
         uploadManager.deleteEntitySymlinkRootDirectoryIfNeeded(mock(DeleteEntityDownloadURLCommand.class), validLinkPath);
         fileUtilMock.verify(() -> FileUtil.deleteRecursively(any(Path.class)), times(1));
     }
+
+    @Test
+    public void deletesSymlinkRootDirectoryWhenNoFile() {
+        String validLinkPath = "123e4567-e89b-12d3-a456-426614174000";
+        uploadManager.deleteEntitySymlinkRootDirectoryIfNeeded(mock(DeleteEntityDownloadURLCommand.class), validLinkPath);
+        fileUtilMock.verify(() -> FileUtil.deleteRecursively(any(Path.class)), times(1));
+    }
 }