Skip to content

chore(deps): autoupdate (needs claude fix)#14

Closed
github-actions[bot] wants to merge 3 commits into
mainfrom
chore/autoupdate-27449135104
Closed

chore(deps): autoupdate (needs claude fix)#14
github-actions[bot] wants to merge 3 commits into
mainfrom
chore/autoupdate-27449135104

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The dependency autoupdater failed during builds-and-checks.

Run log: https://github.com/siarheidudko/firebase-admin-cli/actions/runs/27449135104

A Claude session has been dispatched to push fixes onto this branch
so the following commands all exit 0:

  npm run build
  npm test

Claude will leave a status comment on this PR when it finishes.
PR-checks will re-run on each new commit.

@github-actions github-actions Bot requested a review from siarheidudko June 12, 2026 23:34
@github-actions github-actions Bot added autoupdate Automated dependency update PRs needs-claude Needs Claude GitHub App to fix labels Jun 12, 2026
Replace deprecated namespace-style API (admin.auth(), admin.firestore(),
admin.credential.cert()) with sub-package imports (getAuth, getFirestore,
cert from firebase-admin/app|auth|firestore|database|storage).
Update TypeScript types accordingly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude

claude Bot commented Jun 12, 2026

Copy link
Copy Markdown

Autoupdate status

Initial failures: npm run build failed with 6 TypeScript errors due to firebase-admin v14 removing its namespace-style API (admin.app.App, admin.auth.Auth, admin.database.Database, admin.firestore.Firestore, admin.storage.Storage, and typeof admin.firestore). npm test was not reached.

Root cause: firebase-admin v14.0.0 dropped the legacy namespace exports and the admin.auth() / admin.credential.cert() / etc. convenience methods in favour of sub-package imports (firebase-admin/auth, firebase-admin/app, etc.).

Changes made:

  • src/index.ts: Replaced import type admin from "firebase-admin" (default import) with import type * as admin from "firebase-admin" plus explicit type imports for App, Auth, Database, Firestore, Storage from their respective sub-packages. Replaced namespace-qualified type references (admin.app.App, etc.) with the directly-imported types.
  • bin/firebase-cli.js: Added sub-package requires (firebase-admin/app, /auth, /database, /firestore, /storage). Replaced admin.credential.cert(...)cert(...), admin.initializeApp(...)initializeApp(...), admin.auth()getAuth(app), admin.database()getDatabase(app), admin.firestore()getFirestore(app), admin.storage()getStorage(app), and admin.firestore (types ref) → firestoreNs.

After fix: npm run build exits 0. npm test exits 1 (expected — no SERVICE_ACCOUNT secret in local env; CI will supply it).

Committed and pushed: c400a07 on branch chore/autoupdate-27449135104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoupdate Automated dependency update PRs needs-claude Needs Claude GitHub App to fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant