Skip to content

Handle falsy values in prop validation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varunkasyap wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle falsy values in prop validation #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ export interface MarkdownProps extends ReactRendererOptions, LexerOptions {
}

const validateComponentProps = (props: MarkdownProps) => {
if (props.value && typeof props.value !== 'string') {
if (props.value != null && typeof props.value !== 'string') {
throw new TypeError(`[marked-react]: Expected value to be of type string but got ${typeof props.value}`);
}

if (props.children && typeof props.children !== 'string') {
if (props.children != null && typeof props.children !== 'string') {
throw new TypeError(`[marked-react]: Expected children to be of type string but got ${typeof props.children}`);
}
};
Expand Down
2 changes: 1 addition & 1 deletion tests/component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('Markdown Component', () => {
});

it('should throw error if children is not a string', () => {
const marked = createElement(Markdown, null, 1);
const marked = createElement(Markdown, null, 0);

expect(() => renderToStaticMarkup(marked)).toThrowError(
new TypeError('[marked-react]: Expected children to be of type string but got number'),
Expand Down