Commit 7e6225c
committed
address review feedback from @AlexHladin
- Bump actions/checkout and actions/setup-node to v6 (latest stable)
in both the tests and e2e jobs of .github/workflows/ci.yml
- Bump all example runtimes from nodejs20.x to nodejs22.x. Node 20
reached EOL on April 30 2026; Lambda console removed it then and
function updates will be blocked from Sep 30 2026. Examples should
reflect the current recommended runtime so users copying them get a
supported runtime by default.
- Export AuthenticationType union from src/types/common.ts (derived
from the existing Auth discriminated union via Auth['type']) and
use it in e2e/helpers/assertions.ts instead of duplicating the
literal string union. Keeps the e2e helper and the source of truth
in sync automatically if a new auth type is ever added.
Re: 'why Node 22 for the e2e job and not the full 20/22/24/26 matrix?'
The CFN output produced by serverless package is identical across Node
versions (no Node-specific code paths in synthesis). The existing
unit-test matrix already verifies plugin logic across all four Node
versions; running the synthesis tests across the same matrix would 4x
CI minutes for zero added signal. 22 specifically matches what the
Release workflow uses, keeping CI consistent.1 parent e77ddf0 commit 7e6225c
28 files changed
Lines changed: 33 additions & 35 deletions
File tree
- .github/workflows
- e2e/helpers
- examples
- api-keys-multiple
- basic-api-key
- caching
- cognito-userpools
- custom-domain
- datasource-eventbridge
- datasource-http
- datasource-none
- datasource-opensearch
- datasource-rds
- environment-variables
- iam-auth
- introspection-disabled
- lambda-authorizer
- lambda-resolvers-js
- lambda-resolvers-vtl
- logging-xray
- multi-auth
- oidc-auth
- pipeline-resolvers
- schema-multiple-files
- substitutions
- tags
- visibility-private
- waf
- src/types
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
| 52 | + | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
| 100 | + | |
105 | 101 | | |
106 | 102 | | |
107 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
0 commit comments