Skip to content

Commit 29f3fe3

Browse files
author
ekkoitac
committed
docs: address review comments on Recordly attribution
- Update ATTRIBUTION.md to list clamp01() alongside easeOutScreenStudio() and cubicBezier() - Add inline attribution header comment to mathUtils.ts - Add inline attribution header comment to zoomRegionUtils.ts
1 parent e35780b commit 29f3fe3

4 files changed

Lines changed: 24 additions & 0 deletions

File tree

ATTRIBUTION.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Attribution
2+
3+
OpenScreen thanks the following open-source projects for inspiring and contributing code:
4+
5+
## Zoom & Pan Animation
6+
7+
The zoom and pan animation system in OpenScreen was inspired by and ported from [Recordly](https://github.com/Recordly-dev/Recordly).
8+
9+
The following functions in `src/components/video-editor/videoPlayback/` were ported from Recordly:
10+
11+
- `mathUtils.ts``easeOutScreenStudio()`, `cubicBezier()`, and `clamp01()`
12+
- `zoomRegionUtils.ts` — zoom region strength, chaining, and connected pan transition logic
13+
14+
We apologize for the omission and thank Recordly's maintainers for their excellent work.

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ _I'm new to open source, idk what I'm doing lol. If something is wrong please ra
9494

9595
Contributions are welcome! If you’d like to help out or see what’s currently being worked on, take a look at the open issues and the [project roadmap](https://github.com/users/siddharthvaddem/projects/3) to understand the current direction of the project and find ways to contribute.
9696

97+
## Attribution
98+
99+
Third-party attributions are listed in [ATTRIBUTION.md](./ATTRIBUTION.md).
100+
97101
## License
98102

99103
This project is licensed under the [MIT License](./LICENSE). By using this software, you agree that the authors are not liable for any issues, damages, or claims arising from its use.

src/components/video-editor/videoPlayback/mathUtils.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Ported from Recordly (https://github.com/Recordly-dev/Recordly).
2+
// See ATTRIBUTION.md for details.
3+
14
export function clamp01(value: number) {
25
return Math.max(0, Math.min(1, value));
36
}

src/components/video-editor/videoPlayback/zoomRegionUtils.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Ported from Recordly (https://github.com/Recordly-dev/Recordly).
2+
// See ATTRIBUTION.md for details.
3+
14
import type { ZoomFocus, ZoomRegion } from "../types";
25
import { ZOOM_DEPTH_SCALES } from "../types";
36
import { TRANSITION_WINDOW_MS, ZOOM_IN_TRANSITION_WINDOW_MS } from "./constants";

0 commit comments

Comments
 (0)