Skip to content

Commit 5ff6139

Browse files
committed
fix:addresses comments - clear track.onended before intentional stop to prevent disconnect toast
1 parent b270aff commit 5ff6139

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

src/hooks/useScreenRecorder.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,10 @@ export function useScreenRecorder(): UseScreenRecorderReturn {
204204
});
205205

206206
if (cancelled) {
207-
stream.getTracks().forEach((track) => track.stop());
207+
stream.getTracks().forEach((track) => {
208+
track.onended = null;
209+
track.stop();
210+
});
208211
return;
209212
}
210213

@@ -244,7 +247,10 @@ export function useScreenRecorder(): UseScreenRecorderReturn {
244247
cancelled = true;
245248
webcamReady.current = false;
246249
if (acquiredStream) {
247-
acquiredStream.getTracks().forEach((track) => track.stop());
250+
acquiredStream.getTracks().forEach((track) => {
251+
track.onended = null;
252+
track.stop();
253+
});
248254
webcamStream.current = null;
249255
}
250256
};
@@ -493,8 +499,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {
493499
});
494500
}
495501
if (!webcamStream.current) {
496-
// The useEffect already showed the appropriate error toast
497-
// (cameraNotFound or cameraBlocked), so just disable the state.
498502
setWebcamEnabledState(false);
499503
}
500504
}

0 commit comments

Comments
 (0)