Skip to content

Allow decimal custom playback speeds#637

Closed
muttyqt15 wants to merge 1 commit into
siddharthvaddem:mainfrom
muttyqt15:fix/custom-playback-speed-decimals
Closed

Allow decimal custom playback speeds#637
muttyqt15 wants to merge 1 commit into
siddharthvaddem:mainfrom
muttyqt15:fix/custom-playback-speed-decimals

Conversation

@muttyqt15
Copy link
Copy Markdown

@muttyqt15 muttyqt15 commented May 21, 2026

Summary

  • allow the custom playback speed field to accept decimal values and sub-1 speeds
  • preserve non-preset values like 1.1x instead of rounding them to whole numbers
  • cover the input behavior with a focused component test

Root cause

The custom speed input stripped all non-digits with replace(/\D/g, "") and initialized non-preset values with Math.round(value), so values like 1.1 could not be entered or displayed correctly.

Impact

Users can enter decimal speeds like 1.1x, 0.9x, and other values up to 16x through the custom playback speed control, matching the existing 2-decimal playback speed model.

Validation

  • npm test -- src/components/video-editor/CustomSpeedInput.test.tsx
  • npx tsc --noEmit

Fixes #635.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7695978a-3f01-4750-b0ab-e8f80e2f449c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@muttyqt15 muttyqt15 force-pushed the fix/custom-playback-speed-decimals branch from 8d25ab7 to f4df9d4 Compare May 21, 2026 21:28
@denisfilab
Copy link
Copy Markdown

nice work!

@siddharthvaddem
Copy link
Copy Markdown
Owner

this has been fixed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Custom Playback Speed input does not accept decimal values like 1.1×

3 participants