Allow decimal custom playback speeds#637
Closed
muttyqt15 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8d25ab7 to
f4df9d4
Compare
|
nice work! |
Owner
|
this has been fixed already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.1xinstead of rounding them to whole numbersRoot cause
The custom speed input stripped all non-digits with
replace(/\D/g, "")and initialized non-preset values withMath.round(value), so values like1.1could not be entered or displayed correctly.Impact
Users can enter decimal speeds like
1.1x,0.9x, and other values up to16xthrough the custom playback speed control, matching the existing 2-decimal playback speed model.Validation
npm test -- src/components/video-editor/CustomSpeedInput.test.tsxnpx tsc --noEmitFixes #635.