feat(editor): add center snapping guides for zoom focus and webcam positioning#336
Open
miuuyy wants to merge 1 commit intosiddharthvaddem:mainfrom
Open
feat(editor): add center snapping guides for zoom focus and webcam positioning#336miuuyy wants to merge 1 commit intosiddharthvaddem:mainfrom
miuuyy wants to merge 1 commit intosiddharthvaddem:mainfrom
Conversation
📝 WalkthroughWalkthroughThe VideoPlayback component now includes center snapping behavior for zoom focus and webcam PiP dragging. New state and refs track snap status per axis with hysteresis logic, and visual guide lines render at the center when snapping is active. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds viewport center snapping guides for manual zoom focus placement and picture-in-picture webcam positioning.
When dragging a zoom focus point or webcam overlay near the center axis, the element now snaps softly to the horizontal and/or vertical center line. Subtle guide lines appear while snapping is active, which makes one-axis alignment much easier without introducing new UI controls.
Motivation
Manual positioning is flexible, but it is awkward to align content precisely to the canvas center on only one axis while keeping freedom on the other.
This improves the editing workflow for common composition tasks like:
The implementation is intentionally lightweight and stays inside the viewport interaction model instead of adding extra buttons or coordinate inputs.
Type of Change
Related Issue(s)
N/A
Screenshots / Video
Video (if applicable):
A short demo should show:
Testing
Commands used:
npx tsc --noEmit npm testManual testing:
Checklist
Thank you for contributing!
Summary by CodeRabbit