Dev#477
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR removes internationalization support and simplifies multiple UI components across the video editor and launch window. Changes include redesigning the recording HUD with a simplified horizontal bar, replacing data-driven localized interfaces with hardcoded English text, refactoring color picker logic, and adding a TypeScript deprecation suppression config. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~70 minutes This is kinda cursed—you've got six components getting the i18n ripped out simultaneously, two major UI rewrites (LaunchWindow HUD + SettingsPanel), and a hefty pile of heterogeneous logic changes. The lowkey risky part is the timer logic in LaunchWindow and the color picker rework in AnnotationSettingsPanel—both need careful logic review. The scope is broad and the changes don't follow a single pattern, so reviewers gotta context-switch between recording timers, color pickers, layout refactors, and config changes. High cognitive load overall. Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c0709fbfc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "lib": ["ES2020", "DOM", "DOM.Iterable"], | ||
| "module": "ESNext", | ||
| "skipLibCheck": true, | ||
| "ignoreDeprecations": "6.0", |
There was a problem hiding this comment.
ignoreDeprecations to a supported TypeScript version
The new "ignoreDeprecations": "6.0" value is not accepted by the repository’s TypeScript toolchain, so tsc exits immediately with TS5103 and the build pipeline cannot proceed. This blocks all downstream checks until the option is removed or changed to a supported value.
Useful? React with 👍 / 👎.
| if (!recordingStart) setRecordingStart(Date.now()); | ||
| timer = setInterval(() => { | ||
| if (recordingStart) { | ||
| setElapsed(Math.floor((Date.now() - recordingStart) / 1000)); |
There was a problem hiding this comment.
This effect references recordingStart/setRecordingStart/setElapsed without any corresponding state declarations in the component, so the launch window no longer type-checks. In strict TS builds this fails compilation before runtime, preventing the updated HUD from shipping.
Useful? React with 👍 / 👎.
| <Card | ||
| key={source.id} |
There was a problem hiding this comment.
Card before rendering source tiles
The new source grid now renders <Card> elements, but Card is never imported or defined in this file. That introduces an immediate compile-time failure for the source selector view.
Useful? React with 👍 / 👎.
| </div> | ||
| <div className="flex items-center justify-between"> | ||
| <span className="text-slate-400">Delete Selected</span> | ||
| <kbd className="px-1 py-0.5 bg-white/5 border border-white/10 rounded text-[#34B27B] font-mono">{shortcuts.delete}</kbd> |
There was a problem hiding this comment.
ShortcutsConfig keys in shortcut help
The tooltip now reads shortcuts.delete, shortcuts.pan, and shortcuts.zoom, but ShortcutsConfig only defines keys like deleteSelected and has no pan/zoom entries. This breaks type-checking and would render undefined bindings if forced through.
Useful? React with 👍 / 👎.
| <Colorful | ||
| color={textColorHsva} | ||
| disableAlpha={true} | ||
| onChange={(color) => { | ||
| setTextColorHsva(color.hsva); |
There was a problem hiding this comment.
The panel was switched to Colorful/HSVA-based updates, but this file does not declare or import Colorful, textColorHsva, setTextColorHsva, or hsvaToHex. As written, the annotation settings panel fails to compile and color editing is broken.
Useful? React with 👍 / 👎.
| checked={motionBlurEnabled} | ||
| onCheckedChange={onMotionBlurChange} |
There was a problem hiding this comment.
motionBlurEnabled in SettingsPanel
This switch binds checked to motionBlurEnabled, but no such variable exists in the component props or local state. The settings panel therefore fails strict TypeScript compilation in its current form.
Useful? React with 👍 / 👎.
1 participant
Pull Request Template
Description
Motivation
Type of Change
Related Issue(s)
Screenshots / Video
Screenshot (if applicable):
Video (if applicable):
Testing
Checklist
Thank you for contributing!
Summary by CodeRabbit