Skip to content

Fix stale speed controls in the editor#646

Open
AjTheSpidey wants to merge 1 commit into
siddharthvaddem:mainfrom
AjTheSpidey:codex/editor-settings-scroll
Open

Fix stale speed controls in the editor#646
AjTheSpidey wants to merge 1 commit into
siddharthvaddem:mainfrom
AjTheSpidey:codex/editor-settings-scroll

Conversation

@AjTheSpidey
Copy link
Copy Markdown
Contributor

@AjTheSpidey AjTheSpidey commented May 23, 2026

Fixes #641.

Found this while checking the speed panel. If a speed region was selected and then you switched to zoom, trim, or annotation, the old speed selection could stay active too. That makes the inspector stack the speed controls under the next timeline tool.

This clears the stale speed selection whenever another timeline item becomes active.

Local screenshots:

Speed selected:
Speed selected

After adding/selecting zoom:
Zoom selected after speed

Checked locally:

  • npm.cmd run build-vite
  • node_modules\.bin\biome.cmd check --formatter-enabled=false src/components/video-editor/VideoEditor.tsx
  • Playwright/Electron flow: opened the sample video, added speed, added zoom, and verified the speed panel hides once zoom is active

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 23, 2026

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Playback speed not visible on editor

1 participant