Skip to content

Commit 459b126

Browse files
committed
Fix LookML ${view.field} reference resolution and cycle handling
The reference resolver regex (${name}) never matched dotted refs, so: - self-view-qualified refs (${this_view.field}) leaked the literal ${...} into generated SQL (a hard syntax error); for measures it also broke the metric. Real models (e.g. the GA360 block) use this form pervasively. - cross-view refs (${other_view.field}) likewise leaked literally. - chains deeper than 10 silently truncated; self-references expanded 10x. Normalize self-view qualifiers to bare refs before resolution, make both resolvers dotted-ref aware (cross-view -> qualified column + warning, since sidemantic cannot represent an inline cross-model column), and replace the fixed depth cap with cycle detection so acyclic chains of any depth resolve and circular refs terminate. Note: cross-view field references remain a modeling gap (sidemantic has no inline cross-model column); the adapter now emits a qualified column and warns instead of producing invalid ${...} SQL.
1 parent 08f2939 commit 459b126

2 files changed

Lines changed: 1261 additions & 69 deletions

File tree

0 commit comments

Comments
 (0)