fix: scheduled jobs not stopping with Sidequest#100
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where scheduled jobs were not properly stopped when Sidequest shuts down, and adds comprehensive test coverage for scheduled job functionality.
Key changes:
- Implements a centralized
ScheduledJobRegistryto track and manage scheduled cron jobs - Ensures scheduled jobs are properly stopped during Sidequest shutdown
- Adds integration tests to verify scheduled job behavior and cleanup
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/engine/src/job/cron-registry.ts | New registry class for tracking and managing scheduled cron jobs |
| packages/engine/src/job/cron-registry.test.ts | Comprehensive unit tests for the cron registry functionality |
| packages/engine/src/job/job-builder.ts | Updated to register scheduled tasks with the registry for proper cleanup |
| packages/engine/src/job/index.ts | Exports the new cron registry module |
| packages/engine/src/engine.ts | Ensures scheduled jobs are stopped during engine shutdown |
| tests/integration/shared-test-suite.js | Adds integration tests for scheduled job functionality and cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4 tasks
merencia
approved these changes
Sep 10, 2025
sidequest-release Bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
## [1.7.1](v1.7.0...v1.7.1) (2025-09-10) ### Bug Fixes * scheduled jobs not stopping with Sidequest ([#100](#100)) ([129ee4e](129ee4e))
Contributor
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
yarn test:allandyarn test:integration)Summary of Changes
Closes #95