feat(engine): add config option to override start path for manual job resolution (#108)#109
Closed
faizanu94 wants to merge 3 commits into
Closed
feat(engine): add config option to override start path for manual job resolution (#108)#109faizanu94 wants to merge 3 commits into
faizanu94 wants to merge 3 commits into
Conversation
Contributor
|
Thanks for the contribution. However, that doesn't quite solve the problem. The main problem is that we are using I will work on another PR for a different strategy. The idea is to get a relative path to the file that called Sidequest.start. |
4 tasks
Author
|
Closing in favor of #111 which addresses the root issue. |
Contributor
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
yarn test:allandyarn test:integration)Summary of Changes
This PR adds support for overriding the start path when using manual job resolution in Sidequest:
paths.startin EngineConfig.findSidequestJobsScriptInParentDirsto resolve from explicit override before falling back to existing upward directory search.paths.startwith build outputs.This enables projects that transpile or emit
sidequest.jobs.jsto custom build directories to cleanly configure job resolution without patching the engine.Closes #108