Change su domain from 'su' to 'ksu'#4
Open
gavdoc38 wants to merge 1 commit intosidex15:OpenELA-4.14.y-Stockfrom
Open
Change su domain from 'su' to 'ksu'#4gavdoc38 wants to merge 1 commit intosidex15:OpenELA-4.14.y-Stockfrom
gavdoc38 wants to merge 1 commit intosidex15:OpenELA-4.14.y-Stockfrom
Conversation
Tiniest of things and there will obviously be several larger official SUSFS things to adapt, but I spent ages trying to work out why the sdcard_monitor function was exiting as not su... Turns out KSU & SUSFS official (and your fork) have changed the su domain to 'ksu' and so that needs changed here to match and then it works fine without further changes; there probably are further changes/optimizations but this quickly restores it to working again! I couldn't find many other instances of hardcoding a context like this in the other files, other than with AVC spoofing 'u:r:priv_app:s0:c512,c768' and so unless they suddenly feel the need to rename init, zygote or priv_app, I doubt it's likely to be a problem in future! Feel free to close this without merging as I'm sure you don't need a one character commit, but just to make you aware 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiniest of things and there will obviously be several larger official SUSFS things to adapt, but I spent ages trying to work out why the sdcard_monitor function was exiting as not su... Turns out KSU & SUSFS official (and your fork) have changed the su domain to 'ksu' and so that needs changed here to match and then it works fine without further changes; there probably are further changes/optimizations but this quickly restores it to working again!
I couldn't find many other instances of hardcoding a context like this in the other files, other than with AVC spoofing 'u:r:priv_app:s0:c512,c768' and so unless they suddenly feel the need to rename init, zygote or priv_app, I doubt it's likely to be a problem in future!
Feel free to close this without merging as I'm sure you don't need a one character commit, but just to make you aware 😊