Skip to content

Returning error on pending callbacks when connection dies #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rianhunter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Returning error on pending callbacks when connection dies #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/bus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,16 @@ module.exports = function bus(conn, opts) {
this.connection.message(reply);
};

this.connection.on('end', function() {
// complete all pending callbacks with error
var handler;
for (var cookie in self.cookies) {
handler = self.cookies[cookie];
delete self.cookies[cookie];
handler(new Error("connection was closed"));
}
});

// route reply/error
this.connection.on('message', function(msg) {
var handler;
Expand Down