Skip to content

Add "interpreting" parser#2099

Closed
sidorares wants to merge 1 commit intomasterfrom
deoptimise-large-rows
Closed

Add "interpreting" parser#2099
sidorares wants to merge 1 commit intomasterfrom
deoptimise-large-rows

Conversation

@sidorares
Copy link
Copy Markdown
Owner

WIP, work related to

#2090

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

The coverage rate is 89.19497573508421%

The branch rate is 84.97191011235955%

100% of new lines are covered.

const Types = require('../constants/types.js');
const Charsets = require('../constants/charsets.js');
const helpers = require('../helpers');
const genFunc = require('generate-function');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const genFunc = require('generate-function');

const Charsets = require('../constants/charsets.js');
const helpers = require('../helpers');
const genFunc = require('generate-function');
const parserCache = require('./parser_cache.js');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const parserCache = require('./parser_cache.js');

return packet.parseLengthCodedFloat();
case Types.NULL:
// case Types.BIT:
// return 'packet.readBuffer(2)[1]';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the useless code?

Comment thread lib/commands/query.js
const fields = this._fields[this._resultIndex];
this.emit('fields', fields);
this._rowParser = new (getTextParser(fields, this.options, connection.config))(fields);
if (this.options.useStaticParser) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this option to connection.config.js

waitForConnections: 1

@wellwelwel
Copy link
Copy Markdown
Collaborator

Closing due to #3365.

@wellwelwel wellwelwel closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants