misc changest

[KunZhou-at]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.40%. Comparing base (cf3fa60) to head (4f26387).
Report is 8 commits behind head on master.

Files	Patch %	Lines
lib/connection.js	77.77%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2594      +/-   ##
==========================================
+ Coverage   90.32%   90.40%   +0.08%     
==========================================
  Files          71       71              
  Lines       15717    15716       -1     
  Branches     1333     1333              
==========================================
+ Hits        14196    14208      +12     
+ Misses       1521     1508      -13     

Flag	Coverage Δ
compression-0	90.40% <93.93%> (+0.08%)	⬆️
compression-1	90.40% <93.93%> (+0.08%)	⬆️
tls-0	89.94% <81.81%> (+0.10%)	⬆️
tls-1	90.22% <93.93%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wellwelwel]

Thanks @KunZhou-at. Is this PR an union of the following PRs?

• Fix server identity check #2253
• Fix error code for protocol error #2259
• Add warnings count for non-DML/DLL queries like SELECT #2219
• Fix big number accuracy #2276
• Use the same regex as mysqljs for changed rows #2518

If so, I suggest keeping the focus on them in order to better discuss and generate the changelogs when releasing them 🙋🏻‍♂️

However, it's interesting to know that they all ran 100% in the current tests 🚀

[wellwelwel]

I've replied to each of the PRs mentioned, I'll close this to focus the discussion on them 🙋🏻‍♂️

Please let me know if I'm misjudging this 🤝