ci: improve workflows#3380
Merged
wellwelwel merged 8 commits intosidorares:masterfrom Feb 5, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3380 +/- ##
==========================================
+ Coverage 88.69% 88.77% +0.08%
==========================================
Files 85 85
Lines 13448 13448
Branches 1532 1535 +3
==========================================
+ Hits 11928 11939 +11
+ Misses 1520 1509 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the tests in a way that allows reusing MySQL versions and variations.
Also, MySQL 9 will also run through the coverage workflow, preventing issues like in #3379 (and that's how I discovered the related issue).
Another point is that we only tested version
8.0.x, instead of every minor versions.Now, we test:
mysql:5.7mysql:8.0mysql:8.1(new)mysql:8.2(new)mysql:8.3(new)(soon)mysql:8.4mysql:9.0mysql:9.1(new)mysql:9.2(previously aslatest)I've also reused it better to avoid repeated tests, reducing from 116 to 100 workflows in total.
Finally, I updated all Node.js
20.xto the latest LTS (22).Related
Note