Deepak/path filter include by k-marian-deepak · Pull Request #209 · sidpalas/devops-directive-github-actions-course

k-marian-deepak · 2026-04-17T03:47:16Z

A hands on for the Trigger Event for a specific type of file.

Copilot

Pull request overview

This PR updates several GitHub Actions workflow examples (triggers/filters, jobs/steps, step types) and adds Devbox virtualenv/Poetry hook scripts to support local developer environment setup.

Changes:

Adjusted the triggers/filters workflow (including a commented schedule example) and path filtering for PR events.
Expanded the jobs/steps workflow by adding new jobs and new needs dependencies.
Added Devbox hook scripts for Python venv creation/validation and Poetry environment selection.

Reviewed changes

Copilot reviewed 2 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
03-core-features/filters/excluded-file.txt	Listed as part of the PR’s changed files (intended as an example artifact for path filtering).
.github/workflows/03-core-features--04-triggers-and-filters.yaml	Updates PR path filters and tweaks the commented schedule example formatting.
.github/workflows/03-core-features--03-workflows-jobs-steps.yaml	Adds new jobs and dependencies to demonstrate job relationships in a workflow DAG.
.github/workflows/03-core-features--02-step-types.yaml	Updates example output strings for inline bash/python and action input text.
.devbox/virtenv/python312/bin/venvShellHook.sh	Introduces a shell hook to validate/create a Python venv and handle non-Devbox venvs.
.devbox/virtenv/poetry/bin/initHook.sh	Adds a Poetry init hook to select the Python interpreter for a given pyproject directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-17T03:51:35Z

  ### https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule
  # schedule:
-  #   - cron: "0 0 * * *" # Midnight UTC
+      # - cron: "0 0 * * *" # Midnight UTC


The commented schedule example is mis-indented: # - cron: ... is shown under # schedule: with extra indentation, so if someone uncomments it they’ll end up with invalid YAML. Adjust the comment indentation to match the actual structure (e.g., keep the - cron aligned under schedule:).

Suggested change

# - cron: "0 0 * * *" # Midnight UTC

# - cron: "0 0 * * *" # Midnight UTC

Copilot · 2026-04-17T03:51:36Z

+#!/bin/sh
+set -eu
+STATE_FILE="$DEVBOX_PROJECT_ROOT/.devbox/venv_check_completed"


PR description focuses on path filters/triggers, but this PR also introduces Devbox virtualenv/Poetry hook scripts and modifies other workflow examples. Consider updating the PR description to reflect the broader scope or splitting these unrelated changes into separate PRs to keep review/rollback safer.

Copilot · 2026-04-17T03:51:36Z

    needs:
      - job-1
      - job-2
+      - job-5 # a new job to explore the realtion and working of the jobs in a workflow


Typo in the inline comment: realtion should be relation.

Copilot · 2026-04-17T03:51:36Z

+    needs: 
+      - job-5 # a new job to explore the realtion and working of the jobs in a workflow
    steps:


job-5 is described as “independent”/able to run in parallel, but job-1 and job-3 now both need job-5, which makes it a prerequisite and changes the DAG/parallelism. Either drop the needs: [job-5] dependencies (if the goal is parallelism) or update the job description/comments to match the intended dependency behavior.

Copilot · 2026-04-17T03:51:36Z

+
+create_venv() {
+    python -m venv "$VENV_DIR" --clear
+    echo "*\n.*" >> "$VENV_DIR/.gitignore"


echo "*\n.*" >> "$VENV_DIR/.gitignore" won’t reliably create a two-line .gitignore in POSIX sh (many echo implementations don’t interpret \n), and >> will append duplicates across runs. Use a portable approach (e.g., printf with real newlines) and overwrite the file rather than appending.

Suggested change

echo "*\n.*" >> "$VENV_DIR/.gitignore"

printf '%s\n' '*' '.*' > "$VENV_DIR/.gitignore"

Copilot · 2026-04-17T03:51:36Z

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+poetry env use $(command -v python) --directory="${DEVBOX_PYPROJECT_DIR:-$DEVBOX_DEFAULT_PYPROJECT_DIR}" --no-interaction --quiet >&2


--directory=... is a Poetry global option and typically must appear before the subcommand (e.g., poetry --directory ... env use ...). As written, poetry env use ... --directory=... may be ignored or error depending on Poetry version. Reorder the command to ensure it consistently targets the intended pyproject directory.

Suggested change

poetry env use $(command -v python) --directory="${DEVBOX_PYPROJECT_DIR:-$DEVBOX_DEFAULT_PYPROJECT_DIR}" --no-interaction --quiet >&2

poetry --directory="${DEVBOX_PYPROJECT_DIR:-$DEVBOX_DEFAULT_PYPROJECT_DIR}" env use $(command -v python) --no-interaction --quiet >&2

Copilot · 2026-04-17T03:51:37Z

  job-1:
    runs-on: ubuntu-24.04
+    needs: 
+      - job-5 # a new job to explore the realtion and working of the jobs in a workflow


Typo in the inline comment: realtion should be relation.

Copilot · 2026-04-17T03:51:37Z

 jobs:
  job-1:
    runs-on: ubuntu-24.04
+    needs: 


There’s trailing whitespace after the needs: key (needs: ). This can trip YAML linters and makes diffs noisy; remove the extra space so it’s just needs:.

Suggested change

needs:

needs:

Copilot · 2026-04-17T03:51:37Z

+      - run: echo "This is a second step in the new job of this workflow"
+
+# By Deepak      
+  job-6: 


There’s trailing whitespace after the job id key (job-6: ). Removing it avoids whitespace-only diffs and potential YAML lint failures.

Suggested change

job-6:

job-6:

Copilot · 2026-04-17T03:51:37Z

+            echo "Do you want to overwrite it? (y/n)"
+            read reply
+            echo


This hook prompts with read reply when the venv isn’t a Devbox venv. If this hook runs in a non-interactive context (e.g., devbox run / CI), it will block indefinitely. Consider detecting non-interactive stdin (or honoring an env var default) and failing fast or choosing a safe default behavior.

Suggested change

echo "Do you want to overwrite it? (y/n)"

read reply

echo

if [ "${DEVBOX_VENV_OVERWRITE:-}" != "" ]; then

reply="$DEVBOX_VENV_OVERWRITE"

elif [ -t 0 ]; then

echo "Do you want to overwrite it? (y/n)"

read reply

echo

else

echo "ERROR: Non-interactive shell cannot prompt to overwrite $VENV_DIR."

echo "Set DEVBOX_VENV_OVERWRITE=y to overwrite it, or DEVBOX_VENV_OVERWRITE=n to keep it."

exit 1

fi

k-marian-deepak added 18 commits April 15, 2026 23:05

initial commit / devbox & virtual env setup

ba38924

expereimented / messin around with yaml file

ecbbcab

Hello World

6a97ee2

Step Types - By Deepak

60bd17b

Step Types - By Deepak (name change)

33a923c

Step Types - parallel process

a9c2cca

Step Types - sequencial process

7e85f98

Step Types - parallel process - default - By Deepak

b662930

Own workflow design to undertand the operations better

b3f3ca4

Syntax error fix in new worklow / edit

d5890cc

Another update to the Workflows, Jobs and Steps Action

86b4fb1

Reslove potential error

1ddaf9a

Another .txt file to ignore the trigger

a2c1890

Another .md file to trigger the workflow

2a50aeb

witnssed the corn/timed operation and then turned it into a comment

5d6c41a

A trigger for merge - .md file

8369452

Paths trigger clean up

c70c5bc

A included file to check with the pull request

f595e09

Copilot AI review requested due to automatic review settings April 17, 2026 03:47

Copilot started reviewing on behalf of k-marian-deepak April 17, 2026 03:47 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

A excluded file to check with the pull request

81cc592

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deepak/path filter include#209

Deepak/path filter include#209
k-marian-deepak wants to merge 19 commits intosidpalas:mainfrom
k-marian-deepak:Deepak/path-filter-include

k-marian-deepak commented Apr 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	# - cron: "0 0 * * *" # Midnight UTC
	# - cron: "0 0 * * *" # Midnight UTC

	echo "\n." >> "$VENV_DIR/.gitignore"
	printf '%s\n' '' '.' > "$VENV_DIR/.gitignore"

		@@ -0,0 +1,3 @@
		#!/bin/sh

		poetry env use $(command -v python) --directory="${DEVBOX_PYPROJECT_DIR:-$DEVBOX_DEFAULT_PYPROJECT_DIR}" --no-interaction --quiet >&2

	poetry env use $(command -v python) --directory="${DEVBOX_PYPROJECT_DIR:-$DEVBOX_DEFAULT_PYPROJECT_DIR}" --no-interaction --quiet >&2
	poetry --directory="${DEVBOX_PYPROJECT_DIR:-$DEVBOX_DEFAULT_PYPROJECT_DIR}" env use $(command -v python) --no-interaction --quiet >&2

-            echo "Do you want to overwrite it? (y/n)"
-            read reply
-            echo
+            if [ "${DEVBOX_VENV_OVERWRITE:-}" != "" ]; then
+                reply="$DEVBOX_VENV_OVERWRITE"
+            elif [ -t 0 ]; then
+                echo "Do you want to overwrite it? (y/n)"
+                read reply
+                echo
+            else
+                echo "ERROR: Non-interactive shell cannot prompt to overwrite $VENV_DIR."
+                echo "Set DEVBOX_VENV_OVERWRITE=y to overwrite it, or DEVBOX_VENV_OVERWRITE=n to keep it."
+                exit 1
+            fi

Conversation

k-marian-deepak commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

k-marian-deepak commented Apr 17, 2026 •

edited

Loading