Apply code review fixes: improve documentation and comments

- Fix comment grammar in isAllPortsTCPUDP function
- Fix documentation grammar in egress_firewall.html.markdown
- Move inline comments to function-level documentation
- Address all Copilot review suggestions

Author: sidshas03

cloudstack/resource_cloudstack_egress_firewall.go

@@ -32,7 +32,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
-// treats 'all ports' for tcp/udp across CS versions returning 0/0, -1/-1, or 1/65535
+// isAllPortsTCPUDP determines if a rule represents all ports for TCP/UDP protocols across CloudStack versions that may return 0/0, -1/-1, or 1/65535
 func isAllPortsTCPUDP(protocol string, start, end int) bool {
 	p := strings.ToLower(protocol)
 	if p != "tcp" && p != "udp" {
@@ -732,6 +732,8 @@ func verifyEgressFirewallParams(d *schema.ResourceData) error {
 	return nil
 }
 
+// verifyEgressFirewallRuleParams validates egress firewall rule parameters.
+// Note: ports parameter is optional for TCP/UDP protocols - when omitted, the rule will encompass all ports
 func verifyEgressFirewallRuleParams(d *schema.ResourceData, rule map[string]interface{}) error {
 	protocol := rule["protocol"].(string)
 	if strings.ToLower(protocol) != "all" && protocol != "tcp" && protocol != "udp" && protocol != "icmp" {
@@ -758,8 +760,6 @@ func verifyEgressFirewallRuleParams(d *schema.ResourceData, rule map[string]inte
 				}
 			}
 		}
-		// Note: ports parameter is optional for TCP/UDP protocols
-		// When omitted, the rule will encompass all ports
 	} else if strings.ToLower(protocol) == "all" {
 		if ports, _ := rule["ports"].(*schema.Set); ports.Len() > 0 {
 			return fmt.Errorf(

terraform-provider-cloudstack

@@ -105,7 +105,7 @@ The `rule` block supports:
     the protocol is ICMP.
 
 * `ports` - (Optional) List of ports and/or port ranges to allow. This can only
-    be specified if the protocol is TCP or UDP. For TCP/UDP, omitting `ports` creates an all-ports rule. CloudStack may represent this as empty start/end, `0/0`, or `1/65535`; the provider handles all.
+    be specified if the protocol is TCP or UDP. For TCP/UDP protocols, omitting `ports` creates an all-ports rule. CloudStack may represent this as empty start/end ports, `0/0`, or `1/65535`; the provider handles all formats.
 
 ## Attributes Reference