CRITICAL FIX: Restore delete(rule, 'ports') for all-ports rules

This fixes the core issue causing test failures:
- TestCheckNoResourceAttr expects ports field to be completely absent
- Without delete(rule, 'ports'), the field remains in state
- This was the root cause of the 21 failing GitHub Actions tests

The fix ensures:
- All-ports rules have ports field completely removed from state
- Matches test expectations in TestAccCloudStackEgressFirewall_allPortsTCP
- Fixes both create and read operations for all-ports rules

Author: sidshas03

cloudstack/resource_cloudstack_egress_firewall.go

@@ -331,10 +331,12 @@ func createEgressFirewallRule(d *schema.ResourceData, meta interface{}, rule map
 			// by not setting startport and endport parameters
 			r, err := cs.Firewall.CreateEgressFirewallRule(p)
 			if err != nil {
-				return err
+				return fmt.Errorf("failed to create all-ports egress firewall rule: %w", err)
 			}
 			uuids["all"] = r.Id
 			rule["uuids"] = uuids
+			// Remove the ports field since we're creating an all-ports rule
+			delete(rule, "ports")
 		}
 	}
 
@@ -501,6 +503,8 @@ func resourceCloudStackEgressFirewallRead(d *schema.ResourceData, meta interface
 					// Update the values
 					rule["protocol"] = r.Protocol
 					rule["cidr_list"] = cidrs
+					// Remove ports field for all-ports rules
+					delete(rule, "ports")
 					rules.Add(rule)
 				}
 			}