feat(file-uploader): merge upload texts into single button label#2243
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the file uploader and dropzone components by removing the 'uploadTextFileSelect' input and combining its functionality into the 'uploadDropText' input. The default text is updated to "Drop files here or click to upload". To support this breaking change, a schematic migration ('migration-v51') has been added to automatically remove 'uploadTextFileSelect' from templates during the update to version 51. I have no additional feedback to provide as the changes are clean, well-tested, and include the necessary migrations.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
63a1364 to
9de3c00
Compare
spliffone
added
the
breaking-changes
9de3c00 to
c59731c
Compare
abdc66e to
9b3865c
Compare
The `uploadTextFileSelect` input has been removed. The whole prompt is now rendered as the file-select button text via `uploadDropText`, avoiding fragile translation concatenation. A migration removes leftover usages. BREAKING CHANGE: The `uploadTextFileSelect` input has been removed from `SiFileUploaderComponent` and `SiFileDropzoneComponent`. The full text now lives in `uploadDropText`, which renders as the button. Remove `uploadTextFileSelect` and move its content into `uploadDropText`. Before: ```html <si-file-uploader uploadDropText="Drop files here or" uploadTextFileSelect="click to upload" /> ``` After: ```html <si-file-uploader uploadDropText="Drop files here or click to upload" /> ```
9b3865c to
1d01f18
Compare
3 participants
The
uploadTextFileSelectinput has been removed. The whole prompt is now rendered as the file-select button text viauploadDropText, avoiding fragile translation concatenation. A migration removes leftover usages.BREAKING CHANGE: The
uploadTextFileSelectinput has been removed fromSiFileUploaderComponentandSiFileDropzoneComponent.The full text now lives in
uploadDropText, which renders as the button. RemoveuploadTextFileSelectand move its content intouploadDropText.Before:
After:
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: