fix: make version selection focusable#221
Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the VersionSelection component by removing unused icon imports and enhancing accessibility with the addition of role="button" and tabIndex={0}. Feedback suggests using unique IDs to avoid conflicts when the component is rendered multiple times, e.g. in desktop and mobile navigation. Additionally, keyboard event handlers for the Enter and Space keys should be implemented to ensure full accessibility compliance for users.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
danielleroux
left a comment
danielleroux
left a comment
There was a problem hiding this comment.
Opening and navigating the dropdown will come automatically with the update to iX V5
Even if the keyboard (arrow down) is not working as expected tabbing works also in ix v4
See: https://ix.siemens.io/docs/components/dropdown/code
danielleroux
left a comment
danielleroux
left a comment
There was a problem hiding this comment.
arrow down still not work
There was a problem hiding this comment.
Must be removed otherwise dropdown will not use main version (v5)
2 participants
💡 What is the current behavior?
Version selection not reachable via keyboard
GitHub Issue Number: IX-4111
🆕 What is the new behavior?
👨💻 Help & support