fix(core/input): remove color from eye icon and render it conditionally#2523
fix(core/input): remove color from eye icon and render it conditionally#2523nuke-ellington wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 9c7d080 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ix-input component to conditionally render the password toggle button instead of hiding it with CSS, which improves accessibility and cleans up debug styles. The feedback highlights the need to manually trigger updatePaddings() using a ref callback because shadow DOM changes are not caught by the existing observer. Additionally, the reviewer noted that axe-based accessibility tests should be added to comply with the repository's style guide for component changes.
nuke-ellington
changed the title
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
1 participant
💡 What is the current behavior?
GitHub Issue Number: #
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support