fix(core/breadcrumb): Remove fade-in animation for breadcrumb-item #IX-4265#2549
Conversation
🦋 Changeset detectedLatest commit: 438d20d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the slide-in enter animation from the ix-breadcrumb-item component and cleans up the associated animation logic and imports. The aria-label assignment has been moved from the animation callback to the componentDidLoad lifecycle hook. Feedback was provided regarding the duplication of the aria-label calculation logic, suggesting it be extracted into a helper method to improve maintainability and internationalization.
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
danielleroux
deleted the
chore/IX-4265_remove_breadcrumb_item_enter_animation
branch
3 participants
JIRA ref: IX-4265
💡 What is the current behavior?
There is a fade-in animation in breadcrumb-item component that is barely visible for a fraction for a second.
We have decided to remove it to not interfere with overflow behavior.
🆕 What is the new behavior?
Animation is completely removed.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support