Skip to content

Commit 6b980b4

Browse files
Fix: remove noisy error message when no channels are found for channel query (#21)
* remove noisy error message when no channels are found for a channel query * update plugin validation to allow for failure during CI - use for info only
1 parent 5dcef2f commit 6b980b4

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ jobs:
115115
grafana/plugin-validator-cli -analyzer=metadatavalid /archive.zip
116116
117117
- name: Validate plugin
118+
continue-on-error: true
118119
run: |
119120
npx -y @grafana/plugin-validator@latest -sourceCodeUri file://./ $PLUGIN_ARCHIVE
120121
shell: bash

pkg/plugin/datasource.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,8 @@ func generateQueries(pCtx backend.PluginContext, fqm queryModel, d *SiftDatasour
486486
}
487487

488488
if len(queries) == 0 {
489-
return nil, nil, fmt.Errorf("no matching channels found")
489+
log.DefaultLogger.Debug("No channels found for query", "assetIds", assetIds, "runIds", runIds, "channelQueries", cdq.ChannelQueries)
490490
}
491-
492491
}
493492

494493
return queries, calculatedChannelKeys, nil

0 commit comments

Comments
 (0)