Skip to content

Fix: frontend cache request cancelling#18

Merged
alexluck-sift merged 1 commit into
mainfrom
fix/frontend-cache-request-cancelling
Aug 1, 2025
Merged

Fix: frontend cache request cancelling#18
alexluck-sift merged 1 commit into
mainfrom
fix/frontend-cache-request-cancelling

Conversation

@alexluck-sift

@alexluck-sift alexluck-sift commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Pull Request

Description

Fixes issue where the delta time queries used by the frontend cache (for populating data left and/or right of the cached data) would cancel one another once one completed.

Fix for: FD-169

Type of change

Please check the boxes that apply to this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Validated working by running provisioned dashboard locally and bug no longer present

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please add screenshots to help explain your changes if applicable.

@alexluck-sift alexluck-sift changed the base branch from main to feat/channel-search-single-inflight August 1, 2025 17:54
Base automatically changed from feat/channel-search-single-inflight to main August 1, 2025 19:47
…oid cancelling one another

- Fix issue with joining dataframes on delta cache queries
@alexluck-sift alexluck-sift force-pushed the fix/frontend-cache-request-cancelling branch from 23e1904 to c790b93 Compare August 1, 2025 19:49
@alexluck-sift alexluck-sift marked this pull request as ready for review August 1, 2025 19:49

@bgfreeman7 bgfreeman7 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@alexluck-sift alexluck-sift merged commit 8f0397b into main Aug 1, 2025
11 checks passed
@alexluck-sift alexluck-sift deleted the fix/frontend-cache-request-cancelling branch August 1, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants