Skip to content

Fix: remove noisy error message when no channels are found for channel query #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexluck-sift merged 2 commits into from
Aug 14, 2025
Merged

Fix: remove noisy error message when no channels are found for channel query #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1016e6
remove noisy error message when no channels are found for a channel q…
alexluck-sift Aug 10, 2025
db4940a
update plugin validation to allow for failure during CI - use for inf…
alexluck-sift Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ jobs:
grafana/plugin-validator-cli -analyzer=metadatavalid /archive.zip

- name: Validate plugin
continue-on-error: true
run: |
npx -y @grafana/plugin-validator@latest -sourceCodeUri file://./ $PLUGIN_ARCHIVE
shell: bash
Expand Down
3 changes: 1 addition & 2 deletions pkg/plugin/datasource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,8 @@ func generateQueries(pCtx backend.PluginContext, fqm queryModel, d *SiftDatasour
}

if len(queries) == 0 {
return nil, nil, fmt.Errorf("no matching channels found")
log.DefaultLogger.Debug("No channels found for query", "assetIds", assetIds, "runIds", runIds, "channelQueries", cdq.ChannelQueries)
}

}

return queries, calculatedChannelKeys, nil
Expand Down
Loading