Skip to content

Chore: use sdk http client for health check #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexluck-sift merged 1 commit into from
Feb 10, 2026
Merged

Chore: use sdk http client for health check #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/plugin/check_health.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
// The main use case for these health checks is the test button on the
// datasource configuration page which allows users to verify that
// a datasource is working as expected.
func (d *SiftDatasource) CheckHealth(_ context.Context, req *backend.CheckHealthRequest) (*backend.CheckHealthResult, error) {
func (d *SiftDatasource) CheckHealth(ctx context.Context, req *backend.CheckHealthRequest) (*backend.CheckHealthResult, error) {
u, err := getApiUrl(req.PluginContext.DataSourceInstanceSettings)
if err != nil {
return &backend.CheckHealthResult{
Expand All @@ -23,15 +23,15 @@ func (d *SiftDatasource) CheckHealth(_ context.Context, req *backend.CheckHealth
}, nil
}
u.Path = "/api/v1/me"
request, err := http.NewRequest("GET", u.String(), nil)
request, err := http.NewRequestWithContext(ctx, "GET", u.String(), nil)
if err != nil {
return &backend.CheckHealthResult{
Status: backend.HealthStatusError,
Message: fmt.Sprintf("error creating request: %v", err.Error()),
}, nil
}
request.Header.Set("Authorization", "Bearer "+req.PluginContext.DataSourceInstanceSettings.DecryptedSecureJSONData["apiKey"])
resp, err := http.DefaultClient.Do(request)
resp, err := d.httpClient.Do(request)
if err != nil {
return &backend.CheckHealthResult{
Status: backend.HealthStatusError,
Expand Down
Loading