Fix: Act on early query cancellation#53
Merged
Merged
Conversation
alexluck-sift
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a cancellation request is made while querying data, the cancellation does not flow down to the actual data queries being performed. This can lead to concurrent requests being performed, and unexpected behavior.
We now pass the request context throughout the query call stack, and properly propagate any cancellation signals.
Verification
Queried 90 days of data, then canceled the query using the UI. Then made a second query for a shorter period of time.
Current plugin. A cancellation request appears in the logs, but isn't handled by the initial query. The initial query results return after the second query has completed
With the changes from this PR, the original query is fully canceled upon request. The next query performs as expected