Don't silently cast non-numeric types when evaluating numeric bounds. (#520)

Author: ian-sift

python/lib/sift_client/_tests/util/test_test_results_utils.py

@@ -536,6 +536,15 @@ def test_evaluate_measurement_bounds_with_numeric_bounds_object(self):
         assert measurement.numeric_bounds.min == 0.0
         assert measurement.numeric_bounds.max == 10.0
 
+    def test_numeric_bounds_bad_value_type(self):
+        """Test that an error is raised if the value is not a float or int when evaluating numeric bounds."""
+        measurement = TestMeasurementUpdate()
+        with pytest.raises(
+            TypeError,
+            match="Value must be a float or int to evaluate numeric bounds but gave <class 'str'>",
+        ):
+            evaluate_measurement_bounds(measurement, "1", {"min": 0.0, "max": 10.0})
+
     def test_evaluate_measurement_bounds_string_matching(self):
         """Test string value matching expected string."""
         measurement = TestMeasurementUpdate()

python/lib/sift_client/util/test_results/bounds.py

@@ -70,13 +70,14 @@ def evaluate_measurement_bounds(
     elif isinstance(bounds, NumericBounds):
         measurement.numeric_bounds = bounds
         measurement.passed = True
-        float_value = float(value)
-        if measurement.numeric_bounds.min is not None:
-            measurement.passed = (
-                measurement.passed and measurement.numeric_bounds.min <= float_value
-            )
-        if measurement.numeric_bounds.max is not None:
-            measurement.passed = (
-                measurement.passed and measurement.numeric_bounds.max >= float_value
-            )
+        try:
+            if measurement.numeric_bounds.min is not None:
+                measurement.passed = measurement.passed and measurement.numeric_bounds.min <= value  # type: ignore
+            if measurement.numeric_bounds.max is not None:
+                measurement.passed = measurement.passed and measurement.numeric_bounds.max >= value  # type: ignore
+        except TypeError:
+            raise TypeError(
+                f"Value must be a float or int to evaluate numeric bounds but gave {type(value)}"
+            ) from None
+
     return bool(measurement.passed)