update pre-push hooks

Author: alexluck-sift

.githooks/pre-push

@@ -1,61 +1,24 @@
 #!/usr/bin/env bash
 
-# ensure generated python stubs are up-to-date, from sync clients and sift_stream_bindings
-
 # Store the root directory of the repository
 REPO_ROOT="$(git rev-parse --show-toplevel)"
-PYTHON_DIR="$REPO_ROOT/python"
-BINDINGS_DIR="$REPO_ROOT/rust/crates/sift_stream_bindings"
-STUBS_DIR="$PYTHON_DIR/lib/sift_client/resources/sync_stubs"
-
-# Function to check if generated stub files have changed
-check_stub_changes() {
-    local target_path="$1"
-    local changed_files=$(git status --porcelain "$target_path" | grep -E '\.pyi$' || true)
-
-    if [ -n "$changed_files" ]; then
-        echo "ERROR: Generated python stubs are not up-to-date. Please commit the changed files:"
-        echo "$changed_files"
-        exit 1
-    fi
-}
-
-# Function to generate Python stubs
-generate_python_stubs() {
-    echo "Generating Python stubs..."
-    cd "$PYTHON_DIR"
-
-    if [[ ! -d "$PYTHON_DIR/venv" ]]; then
-        echo "Running bootstrap script..."
-        bash ./scripts/dev bootstrap
-    fi
-
-    bash ./scripts/dev gen-stubs
-    check_stub_changes "$STUBS_DIR"
-}
+GITHOOKS_DIR="$REPO_ROOT/.githooks"
 
-# Function to generate bindings stubs
-generate_bindings_stubs() {
-    echo "Generating bindings stubs..."
-    cd "$BINDINGS_DIR"
-    cargo run --bin stub_gen
-
-    # The stub file is generated in the bindings directory
-    local stub_file="$BINDINGS_DIR/sift_stream_bindings.pyi"
-    check_stub_changes "$stub_file"
-}
-
-# Check for changes in relevant files
+# Check for changes in Python files
 python_changed_files=($(git diff --name-only --diff-filter=ACM | grep '^python/lib/sift_client/' || true))
-bindings_changed_files=($(git diff --name-only --diff-filter=ACM | grep '^rust/crates/sift_stream_bindings/src/' || true))
 
-# Generate stubs if needed
 if [[ -n "$python_changed_files" ]]; then
-    generate_python_stubs
+    echo "Python files changed, running Python stub checks..."
+    bash "$GITHOOKS_DIR/pre-push-python/stubs.sh"
 fi
 
+# Check for changes in Rust bindings files
+bindings_changed_files=($(git diff --name-only --diff-filter=ACM | grep '^rust/crates/sift_stream_bindings/src/' || true))
+
 if [[ -n "$bindings_changed_files" ]]; then
-    generate_bindings_stubs
+    echo "Rust bindings files changed, running Rust stub checks..."
+    bash "$GITHOOKS_DIR/pre-push-rust/stubs.sh"
 fi
 
-echo "All stubs are up-to-date."
+echo "Pre-push checks completed successfully."
+

.githooks/pre-push-python/stubs.sh

@@ -0,0 +1,36 @@
+# ensure generated python stubs are up-to-date, from sync clients
+
+# Store the root directory of the repository
+REPO_ROOT="$(git rev-parse --show-toplevel)"
+PYTHON_DIR="$REPO_ROOT/python"
+STUBS_DIR="$PYTHON_DIR/lib/sift_client/resources/sync_stubs"
+
+# Function to check if generated stub files have changed
+check_stub_changes() {
+    local target_path="$1"
+    local changed_files=$(git status --porcelain "$target_path" | grep -E '\.pyi$' || true)
+
+    if [ -n "$changed_files" ]; then
+        echo "ERROR: Generated python stubs are not up-to-date. Please commit the changed files:"
+        echo "$changed_files"
+        exit 1
+    fi
+}
+
+# Function to generate Python stubs
+generate_python_stubs() {
+    echo "Generating Python stubs..."
+    cd "$PYTHON_DIR"
+
+    if [[ ! -d "$PYTHON_DIR/venv" ]]; then
+        echo "Running bootstrap script..."
+        bash ./scripts/dev bootstrap
+    fi
+
+    bash ./scripts/dev gen-stubs
+    check_stub_changes "$STUBS_DIR"
+}
+
+generate_python_stubs
+
+echo "All stubs are up-to-date."

.githooks/pre-push-rust/stubs.sh

@@ -0,0 +1,32 @@
+# ensure generated python stubs are up-to-date, from sift_stream_bindings
+
+# Store the root directory of the repository
+REPO_ROOT="$(git rev-parse --show-toplevel)"
+BINDINGS_DIR="$REPO_ROOT/rust/crates/sift_stream_bindings"
+
+# Function to check if generated stub files have changed
+check_stub_changes() {
+    local target_path="$1"
+    local changed_files=$(git status --porcelain "$target_path" | grep -E '\.pyi$' || true)
+
+    if [ -n "$changed_files" ]; then
+        echo "ERROR: Generated python stubs are not up-to-date. Please commit the changed files:"
+        echo "$changed_files"
+        exit 1
+    fi
+}
+
+# Function to generate bindings stubs
+generate_bindings_stubs() {
+    echo "Generating bindings stubs..."
+    cd "$BINDINGS_DIR"
+    cargo run --bin stub_gen
+
+    # The stub file is generated in the bindings directory
+    local stub_file="$BINDINGS_DIR/sift_stream_bindings.pyi"
+    check_stub_changes "$stub_file"
+}
+
+generate_bindings_stubs
+
+echo "All stubs are up-to-date."