Remove type hint

Author: ian-sift

python/lib/sift_client/_internal/low_level_wrappers/ingestion.py

@@ -236,7 +236,7 @@ async def get_ingestion_config_id_from_client_key(self, client_key: str) -> str
             raise ValueError(
                 f"Expected 1 ingestion config for client key {client_key}, got {len(ingestion_configs)}"
             )
-        return ingestion_configs[0].id
+        return ingestion_configs[0].id_
 
     def _new_ingestion_thread(
         self, ingestion_config_id: str, ingestion_config: IngestionConfigFormPy | None = None

python/lib/sift_client/_internal/low_level_wrappers/rules.py

@@ -73,9 +73,6 @@ async def get_rule(self, rule_id: str | None = None, client_key: str | None = No
         Raises:
             ValueError: If neither rule_id nor client_key is provided.
         """
-        if rule_id is None and client_key is None:
-            raise ValueError("Either rule_id or client_key must be provided")
-
         request_kwargs: dict[str, Any] = {}
         if rule_id is not None:
             request_kwargs["rule_id"] = rule_id
@@ -223,17 +220,16 @@ def _update_rule_request_from_update(
         # Special handling for the more complex fields.
         # Also, these must always be set.
         expression = model_dump.get("expression", rule.expression)
-        channel_references = (
+        channel_references: List[ChannelReference] = (
             update.channel_references
             if "channel_references" in model_dump
             else rule.channel_references
-        )
+        ) or []
         action = update.action if "action" in model_dump else rule.action
         if bool(expression) != bool(channel_references):
             raise ValueError(
                 "Expression and channel_references must both be provided or both be None"
             )
-        assert channel_references is not None  # make mypy happy
         expression_proto = RuleConditionExpression(
             calculated_channel=CalculatedChannelConfig(
                 expression=expression,

python/lib/sift_client/types/ingestion.py

@@ -34,7 +34,6 @@ class IngestionConfig(BaseType[IngestionConfigProto, "IngestionConfig"]):
     Model of the Sift Ingestion Config.
     """
 
-    id: str
     asset_id: str
     client_key: str
 
@@ -43,7 +42,7 @@ def _from_proto(
         cls, proto: IngestionConfigProto, sift_client: SiftClient | None = None
     ) -> "IngestionConfig":
         return cls(
-            id=proto.ingestion_config_id,
+            id_=proto.ingestion_config_id,
             asset_id=proto.asset_id,
             client_key=proto.client_key,
             _client=sift_client,
@@ -79,7 +78,6 @@ def _to_rust_config(self) -> FlowConfigPy:
 
     def add_channel(self, channel: Channel):
         if self.ingestion_config_id:
-            # TODO: Do we allow this or not?
             raise ValueError("Cannot add a channel to a flow after creation")
         self.channels.append(channel)
 
@@ -188,7 +186,6 @@ def _to_rust_value(channel: Channel, value: Any) -> IngestWithConfigDataChannelV
 
 
 def _to_rust_type(data_type: ChannelDataType) -> ChannelDataTypePy:
-    # TODO: Make more elegant?
     if data_type == ChannelDataType.DOUBLE:
         return ChannelDataTypePy.Double
     elif data_type == ChannelDataType.FLOAT: