Skip to content

Commit 3f137c6

Browse files
committed
bug fixes
1 parent 52ed704 commit 3f137c6

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

python/lib/sift_client/_internal/low_level_wrappers/calculated_channels.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ async def list_calculated_channel_versions(
229229
raise ValueError("Either calculated_channel_id or client_key must be provided")
230230

231231
if page_size is not None:
232-
request_kwargs["page_size"] = str(page_size)
232+
request_kwargs["page_size"] = page_size
233233
if page_token is not None:
234234
request_kwargs["page_token"] = page_token
235235
if query_filter is not None:
@@ -239,7 +239,7 @@ async def list_calculated_channel_versions(
239239
if organization_id is not None:
240240
request_kwargs["organization_id"] = organization_id
241241

242-
request = ListCalculatedChannelVersionsRequest(**request_kwargs) # type: ignore # mypy thinks we should pass an int
242+
request = ListCalculatedChannelVersionsRequest(**request_kwargs)
243243
response = await self._grpc_client.get_stub(
244244
CalculatedChannelServiceStub
245245
).ListCalculatedChannelVersions(request)

python/lib/sift_client/util/test_results/pytest_util.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,14 @@ def _report_context_impl(
7777
request: pytest.FixtureRequest,
7878
pytestconfig: pytest.Config | None = None,
7979
) -> Generator[ReportContext | None, None, None]:
80-
test_path = Path(request.config.invocation_params.args[0])
81-
base_name = (
82-
test_path.name
83-
if test_path.exists()
84-
else "pytest " + " ".join(request.config.invocation_params.args)
85-
)
86-
test_case = test_path if test_path.exists() else base_name
80+
args = request.config.invocation_params.args
81+
test_path = Path(args[0]) if args else None
82+
if test_path is not None and test_path.exists():
83+
base_name = test_path.name
84+
test_case: Path | str = test_path
85+
else:
86+
base_name = "pytest " + " ".join(args) if args else "pytest"
87+
test_case = base_name
8788
log_file = _resolve_log_file(pytestconfig)
8889
include_git_metadata = (
8990
bool(pytestconfig.getoption("sift_test_results_git_metadata", default=True))

0 commit comments

Comments
 (0)