Skip to content

Commit 4b1eb2c

Browse files
committed
update update classes
1 parent 6aedd6b commit 4b1eb2c

4 files changed

Lines changed: 25 additions & 10 deletions

File tree

python/lib/sift_client/sift_types/asset.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ class AssetUpdate(ModelUpdate[AssetProto]):
104104
"""Model of the Asset Fields that can be updated."""
105105

106106
tags: list[str] | None = None
107-
archived_date: datetime | str | None = None
108107
metadata: dict[str, str | float | bool] | None = None
109108
is_archived: bool | None = None
110109

python/lib/sift_client/sift_types/calculated_channel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ class CalculatedChannelUpdate(CalculatedChannelBase, ModelUpdate[CalculatedChann
201201
"""Update model for a Calculated Channel."""
202202

203203
name: str | None = None
204-
archived_date: datetime | None = None
204+
is_archived: bool | None = None
205205

206206
@model_validator(mode="after")
207207
def _validate_non_updatable_fields(self):

python/lib/sift_client/sift_types/rule.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,8 @@ class RuleVersion(BaseType[RuleVersionProto, "RuleVersion"]):
315315
created_by_user_id: str
316316
version_notes: str
317317
generated_change_message: str
318-
deleted_date: datetime | None = None
318+
archived_date: datetime | None
319+
is_archived: bool
319320

320321
@classmethod
321322
def _from_proto(
@@ -329,6 +330,7 @@ def _from_proto(
329330
created_by_user_id=proto.created_by_user_id,
330331
version_notes=proto.version_notes,
331332
generated_change_message=proto.generated_change_message,
332-
deleted_date=proto.deleted_date.ToDatetime() if proto.deleted_date else None,
333+
archived_date=proto.archived_date.ToDatetime() if proto.archived_date else None,
334+
is_archived=proto.is_archived,
333335
_client=sift_client,
334336
)

python/lib/sift_client/sift_types/run.py

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,17 @@ class RunCreate(RunBase, ModelCreate[CreateRunRequestProto]):
121121

122122
name: str
123123
client_key: str | None = None
124+
tags: list[str] | None = None
125+
metadata: dict[str, str | float | bool] | None = None
126+
start_time: datetime | None = None
127+
stop_time: datetime | None = None
128+
organization_id: str | None = None
129+
130+
_to_proto_helpers: ClassVar = {
131+
"metadata": MappingHelper(
132+
proto_attr_path="metadata", update_field="metadata", converter=metadata_dict_to_proto
133+
),
134+
}
124135

125136
def _get_proto_class(self) -> type[CreateRunRequestProto]:
126137
return CreateRunRequestProto
@@ -130,14 +141,17 @@ class RunUpdate(RunBase, ModelUpdate[RunProto]):
130141
"""Update model for Run."""
131142

132143
name: str | None = None
144+
tags: list[str] | None = None
145+
metadata: dict[str, str | float | bool] | None = None
146+
start_time: datetime | None = None
147+
stop_time: datetime | None = None
133148
is_archived: bool | None = None
134149

135-
@model_validator(mode="after")
136-
def _validate_non_updatable_fields(self):
137-
"""Validate that the fields that cannot be updated are not set."""
138-
if self.client_key is not None:
139-
raise ValueError("Cannot update client key")
140-
return self
150+
_to_proto_helpers: ClassVar = {
151+
"metadata": MappingHelper(
152+
proto_attr_path="metadata", update_field="metadata", converter=metadata_dict_to_proto
153+
),
154+
}
141155

142156
def _get_proto_class(self) -> type[RunProto]:
143157
return RunProto

0 commit comments

Comments
 (0)