test hooks

Author: alexluck-sift

.githooks/pre-push

@@ -4,36 +4,49 @@
 REPO_ROOT="$(git rev-parse --show-toplevel)"
 GITHOOKS_DIR="$REPO_ROOT/.githooks"
 
-# Check for changes in Python files
-python_changed_files=($(git diff --name-only --diff-filter=ACM | grep '^python/' || true))
-
-echo "Changed Python files:"
-echo "  ${python_changed_files[*]}"
+echo "========================================"
+echo "  Pre-Push Checks"
+echo "========================================"
 echo
 
+# Check for changes in Python files
+# Compare against the remote branch being pushed to
+python_changed_files=($(git diff --name-only --diff-filter=ACM @{upstream}... | grep '^python/' || true))
+
+echo "→ Python files changed:"
 if [[ -n "$python_changed_files" ]]; then
-    echo "Python files changed, running Python formatting and linting..."
+    echo "  ${python_changed_files[*]}"
+    echo
+    echo "  [1/3] Formatting and linting..."
     bash "$GITHOOKS_DIR/pre-push-python/fmt-lint.sh"
 
-    echo "Running Python stub checks..."
+    echo "  [2/3] Stub generation..."
     bash "$GITHOOKS_DIR/pre-push-python/stubs.sh"
 
-    echo "Running Python extras checks..."
+    echo "  [3/3] Extras validation..."
     bash "$GITHOOKS_DIR/pre-push-python/extras.sh"
+    echo
+else
+    echo "  (none)"
+    echo
 fi
 
 # Check for changes in Rust bindings files
-bindings_changed_files=($(git diff --name-only --diff-filter=ACM | grep '^rust/crates/sift_stream_bindings/src/' || true))
-
-echo
-echo "Changed SiftStream Python bindings files:"
-echo "  ${bindings_changed_files[*]}"
-echo
+bindings_changed_files=($(git diff --name-only --diff-filter=ACM @{upstream}... | grep '^rust/crates/sift_stream_bindings/src/' || true))
 
+echo "→ Rust binding files changed:"
 if [[ -n "$bindings_changed_files" ]]; then
-    echo "Rust bindings files changed, running Rust stub checks..."
+    echo "  ${bindings_changed_files[*]}"
+    echo
+    echo "  [1/1] Stub generation..."
     bash "$GITHOOKS_DIR/pre-push-rust/stubs.sh"
+    echo
+else
+    echo "  (none)"
+    echo
 fi
 
-echo "Pre-push checks completed successfully."
+echo "========================================"
+echo "  ✓ All checks passed"
+echo "========================================"
 

.githooks/pre-push-python/extras.sh

@@ -11,19 +11,20 @@ check_extras_changes() {
     local changed_files=$(git status --porcelain "$target_path" || true)
 
     if [ -n "$changed_files" ]; then
-        echo "❌ ERROR: Generated pyproject.toml extras are not up-to-date. Please commit the changed files:"
-        echo "$changed_files"
+        echo "     ✗ ERROR: Generated extras are not up-to-date:"
+        echo "$changed_files" | sed 's/^/       /'
+        echo "     Please commit these changes before pushing."
         exit 1
     fi
 }
 
 # Function to generate Python extras
 generate_python_extras() {
-    echo "Generating Python extras..."
+    echo "     → Generating extras..."
     cd "$PYTHON_DIR"
 
     if [[ ! -d "$PYTHON_DIR/venv" ]]; then
-        echo "Running bootstrap script..."
+        echo "     → Running bootstrap script..."
         bash ./scripts/dev bootstrap
     fi
 
@@ -33,4 +34,4 @@ generate_python_extras() {
 
 generate_python_extras
 
-echo "All extras are up-to-date."
+echo "     ✓ Extras are up-to-date"

.githooks/pre-push-python/fmt-lint.sh

@@ -6,17 +6,15 @@ set -e
 REPO_ROOT="$(git rev-parse --show-toplevel)"
 PYTHON_DIR="$REPO_ROOT/python"
 
-echo "Running Python formatting and linting with --fix..."
-
 # Change to Python directory
 cd "$PYTHON_DIR"
 
 # Run ruff format (formatter)
-echo "Running ruff format..."
+echo "     → Running ruff format..."
 bash ./scripts/dev fmt
 
 # Run ruff check with --fix (linter)
-echo "Running ruff check --fix..."
+echo "     → Running ruff check --fix..."
 bash ./scripts/dev lint-fix
 
 # Check if any files were modified by formatting/linting
@@ -25,11 +23,11 @@ changed_files=$(git status --porcelain python/lib/sift_client/ | grep -E '\.py$'
 
 if [ -n "$changed_files" ]; then
     echo ""
-    echo "❌ ERROR: Formatting/linting made changes to the following files:"
-    echo "$changed_files"
+    echo "     ✗ ERROR: Formatting/linting made changes:"
+    echo "$changed_files" | sed 's/^/       /'
     echo ""
-    echo "Please commit these changes before pushing."
+    echo "     Please commit these changes before pushing."
     exit 1
 fi
 
-echo "Python formatting and linting completed successfully."
+echo "     ✓ Formatting and linting passed"

.githooks/pre-push-python/stubs.sh

@@ -11,19 +11,20 @@ check_stub_changes() {
     local changed_files=$(git status --porcelain "$target_path" | grep -E '\.pyi$' || true)
 
     if [ -n "$changed_files" ]; then
-        echo "❌ ERROR: Generated python stubs are not up-to-date. Please commit the changed files:"
-        echo "$changed_files"
+        echo "     ✗ ERROR: Generated stubs are not up-to-date:"
+        echo "$changed_files" | sed 's/^/       /'
+        echo "     Please commit these changes before pushing."
         exit 1
     fi
 }
 
 # Function to generate Python stubs
 generate_python_stubs() {
-    echo "Generating Python stubs..."
+    echo "     → Generating stubs..."
     cd "$PYTHON_DIR"
 
     if [[ ! -d "$PYTHON_DIR/venv" ]]; then
-        echo "Running bootstrap script..."
+        echo "     → Running bootstrap script..."
         bash ./scripts/dev bootstrap
     fi
 
@@ -33,4 +34,4 @@ generate_python_stubs() {
 
 generate_python_stubs
 
-echo "All stubs are up-to-date."
+echo "     ✓ Stubs are up-to-date"

.githooks/pre-push-rust/stubs.sh

@@ -10,15 +10,16 @@ check_stub_changes() {
     local changed_files=$(git status --porcelain "$target_path" | grep -E '\.pyi$' || true)
 
     if [ -n "$changed_files" ]; then
-        echo "ERROR: Generated python stubs are not up-to-date. Please commit the changed files:"
-        echo "$changed_files"
+        echo "     ✗ ERROR: Generated stubs are not up-to-date:"
+        echo "$changed_files" | sed 's/^/       /'
+        echo "     Please commit these changes before pushing."
         exit 1
     fi
 }
 
 # Function to generate bindings stubs
 generate_bindings_stubs() {
-    echo "Generating bindings stubs..."
+    echo "     → Generating stubs..."
     cd "$BINDINGS_DIR"
     cargo run --bin stub_gen
 
@@ -29,4 +30,4 @@ generate_bindings_stubs() {
 
 generate_bindings_stubs
 
-echo "All stubs are up-to-date."
+echo "     ✓ Stubs are up-to-date"

python/pyproject.toml

@@ -119,8 +119,6 @@ development = [
     'tomlkit~=0.13.3',
 ]
 
-
-
 docs = [
     'griffe-pydantic',
     'mike',