mypy

Author: ian-sift

python/lib/sift_client/_internal/low_level_wrappers/test_results.py

@@ -179,7 +179,7 @@ def simulate_update_test_report_response(
         if "run_id" in update_mask_paths:
             updates["run_id"] = proto.run_id if proto.run_id else None
         if "metadata" in update_mask_paths:
-            updates["metadata"] = metadata_proto_to_dict(proto.metadata)
+            updates["metadata"] = metadata_proto_to_dict(proto.metadata)  # type: ignore
         if "is_archived" in update_mask_paths:
             updates["is_archived"] = proto.is_archived
 
@@ -889,78 +889,79 @@ async def replay_log_file(
                 json_str = match.group(3)
 
                 if request_type == "CreateTestReport":
-                    request = CreateTestReportRequest()
-                    json_format.Parse(json_str, request)
-                    simulated_proto = self.simulate_create_test_report_response(request)
+                    create_report_req = CreateTestReportRequest()
+                    json_format.Parse(json_str, create_report_req)
+                    report_proto = self.simulate_create_test_report_response(create_report_req)
                     if response_id:
-                        simulated_proto.test_report_id = response_id
-                    simulated_report = TestReport._from_proto(simulated_proto)
+                        report_proto.test_report_id = response_id
+                    simulated_report = TestReport._from_proto(report_proto)
 
                 elif request_type == "CreateTestStep":
-                    request = CreateTestStepRequest()
-                    json_format.Parse(json_str, request)
-                    simulated_proto = self.simulate_create_test_step_response(request)
+                    create_step_req = CreateTestStepRequest()
+                    json_format.Parse(json_str, create_step_req)
+                    step_proto = self.simulate_create_test_step_response(create_step_req)
                     if response_id:
-                        simulated_proto.test_step_id = response_id
-                    step = TestStep._from_proto(simulated_proto)
+                        step_proto.test_step_id = response_id
+                    step = TestStep._from_proto(step_proto)
                     simulated_steps_by_id[step._id_or_error] = step
                     simulated_steps_order.append(step._id_or_error)
 
                 elif request_type == "CreateTestMeasurement":
-                    request = CreateTestMeasurementRequest()
-                    json_format.Parse(json_str, request)
-                    simulated_proto = self.simulate_create_test_measurement_response(request)
+                    create_meas_req = CreateTestMeasurementRequest()
+                    json_format.Parse(json_str, create_meas_req)
+                    meas_proto = self.simulate_create_test_measurement_response(create_meas_req)
                     if response_id:
-                        simulated_proto.measurement_id = response_id
-                    measurement = TestMeasurement._from_proto(simulated_proto)
+                        meas_proto.measurement_id = response_id
+                    measurement = TestMeasurement._from_proto(meas_proto)
                     simulated_measurements_by_id[measurement._id_or_error] = measurement
                     simulated_measurements_order.append(measurement._id_or_error)
 
                 elif request_type == "CreateTestMeasurements":
-                    request = CreateTestMeasurementsRequest()
-                    json_format.Parse(json_str, request)
+                    create_batch_req = CreateTestMeasurementsRequest()
+                    json_format.Parse(json_str, create_batch_req)
                     original_ids = response_id.split(",") if response_id else []
-                    for i, tm_proto in enumerate(request.test_measurements):
+                    for i, tm_proto in enumerate(create_batch_req.test_measurements):
                         single_request = CreateTestMeasurementRequest(test_measurement=tm_proto)
-                        simulated_proto = self.simulate_create_test_measurement_response(
+                        batch_meas_proto = self.simulate_create_test_measurement_response(
                             single_request
                         )
                         if i < len(original_ids):
-                            simulated_proto.measurement_id = original_ids[i]
-                        measurement = TestMeasurement._from_proto(simulated_proto)
+                            batch_meas_proto.measurement_id = original_ids[i]
+                        measurement = TestMeasurement._from_proto(batch_meas_proto)
                         simulated_measurements_by_id[measurement._id_or_error] = measurement
                         simulated_measurements_order.append(measurement._id_or_error)
 
                 elif request_type == "UpdateTestReport":
                     if simulated_report is None:
                         raise ValueError("UpdateTestReport found before CreateTestReport")
-                    request = UpdateTestReportRequest()
-                    json_format.Parse(json_str, request)
+                    update_report_req = UpdateTestReportRequest()
+                    json_format.Parse(json_str, update_report_req)
                     simulated_report = self.simulate_update_test_report_response(
-                        request, existing=simulated_report
+                        update_report_req, existing=simulated_report
                     )
 
                 elif request_type == "UpdateTestStep":
-                    request = UpdateTestStepRequest()
-                    json_format.Parse(json_str, request)
-                    step_id = request.test_step.test_step_id
+                    update_step_req = UpdateTestStepRequest()
+                    json_format.Parse(json_str, update_step_req)
+                    step_id = update_step_req.test_step.test_step_id
                     if step_id not in simulated_steps_by_id:
                         raise ValueError(f"UpdateTestStep for unknown step: {step_id}")
                     simulated_steps_by_id[step_id] = self.simulate_update_test_step_response(
-                        request, existing=simulated_steps_by_id[step_id]
+                        update_step_req, existing=simulated_steps_by_id[step_id]
                     )
 
                 elif request_type == "UpdateTestMeasurement":
-                    request = UpdateTestMeasurementRequest()
-                    json_format.Parse(json_str, request)
-                    measurement_id = request.test_measurement.measurement_id
+                    update_meas_req = UpdateTestMeasurementRequest()
+                    json_format.Parse(json_str, update_meas_req)
+                    measurement_id = update_meas_req.test_measurement.measurement_id
                     if measurement_id not in simulated_measurements_by_id:
                         raise ValueError(
                             f"UpdateTestMeasurement for unknown measurement: {measurement_id}"
                         )
                     simulated_measurements_by_id[measurement_id] = (
                         self.simulate_update_test_measurement_response(
-                            request, existing=simulated_measurements_by_id[measurement_id]
+                            update_meas_req,
+                            existing=simulated_measurements_by_id[measurement_id],
                         )
                     )
 

python/lib/sift_client/_internal/rest.py

@@ -6,7 +6,7 @@
 from typing_extensions import NotRequired
 from urllib3.util import Retry
 
-from sift_client._internal.grpc.transport import _clean_uri
+from sift_client._internal.grpc_transport.transport import _clean_uri
 
 _DEFAULT_REST_RETRY = Retry(total=3, status_forcelist=[500, 502, 503, 504], backoff_factor=1)
 

python/lib/sift_client/resources/sync_stubs/__init__.pyi

@@ -13,6 +13,9 @@ if TYPE_CHECKING:
     import pandas as pd
     import pyarrow as pa
 
+    from sift_client._internal.low_level_wrappers.test_results import (
+        ReplayResult,
+    )
     from sift_client.client import SiftClient
     from sift_client.sift_types.asset import Asset, AssetUpdate
     from sift_client.sift_types.calculated_channel import (
@@ -1703,49 +1706,60 @@ class TestResultsAPI:
         """
         ...
 
-    def create(self, test_report: TestReportCreate | dict) -> TestReport:
+    def create(
+        self, test_report: TestReportCreate | dict, log_file: str | Path | None = None
+    ) -> TestReport:
         """Create a new test report.
 
         Args:
             test_report: The test report to create (can be TestReport or TestReportCreate).
+            log_file: If set, log the request to this file and return a simulated response.
 
         Returns:
             The created TestReport.
         """
         ...
 
     def create_measurement(
-        self, test_measurement: TestMeasurementCreate | dict, update_step: bool = False
+        self,
+        test_measurement: TestMeasurementCreate | dict,
+        update_step: bool = False,
+        log_file: str | Path | None = None,
     ) -> TestMeasurement:
         """Create a new test measurement.
 
         Args:
             test_measurement: The test measurement to create (can be TestMeasurement or TestMeasurementCreate).
             update_step: Whether to update the step to failed if the measurement is being created is failed.
+            log_file: If set, log the request to this file and return a simulated response.
 
         Returns:
             The created TestMeasurement.
         """
         ...
 
     def create_measurements(
-        self, test_measurements: list[TestMeasurementCreate]
+        self, test_measurements: list[TestMeasurementCreate], log_file: str | Path | None = None
     ) -> tuple[int, list[str]]:
         """Create multiple test measurements in a single request.
 
         Args:
             test_measurements: The test measurements to create.
+            log_file: If set, log the request to this file and return a simulated response.
 
         Returns:
             A tuple of (measurements_created_count, measurement_ids).
         """
         ...
 
-    def create_step(self, test_step: TestStepCreate | dict) -> TestStep:
+    def create_step(
+        self, test_step: TestStepCreate | dict, log_file: str | Path | None = None
+    ) -> TestStep:
         """Create a new test step.
 
         Args:
             test_step: The test step to create (can be TestStep or TestStepCreate).
+            log_file: If set, log the request to this file and return a simulated response.
 
         Returns:
             The created TestStep.
@@ -1949,6 +1963,21 @@ class TestResultsAPI:
         """
         ...
 
+    def replay_log_file(self, log_file: str | Path) -> ReplayResult:
+        """Replay a log file by parsing each entry, simulating the results, then creating for real.
+
+        This method reads a log file created by the simulation logging, reconstructs
+        all the objects via simulation, and then creates them via the actual API.
+        IDs are mapped from simulated to real during the creation process.
+
+        Args:
+            log_file: Path to the log file to replay.
+
+        Returns:
+            A ReplayResult containing the created report, steps, and measurements.
+        """
+        ...
+
     def unarchive(self, *, test_report: str | TestReport) -> TestReport:
         """Unarchive a test report.
 
@@ -1957,12 +1986,18 @@ class TestResultsAPI:
         """
         ...
 
-    def update(self, test_report: str | TestReport, update: TestReportUpdate | dict) -> TestReport:
+    def update(
+        self,
+        test_report: str | TestReport,
+        update: TestReportUpdate | dict,
+        log_file: str | Path | None = None,
+    ) -> TestReport:
         """Update a TestReport.
 
         Args:
             test_report: The TestReport or test report ID to update.
             update: Updates to apply to the TestReport.
+            log_file: If set, log the request to this file and return a simulated response.
 
         Returns:
             The updated TestReport.
@@ -1974,25 +2009,33 @@ class TestResultsAPI:
         test_measurement: TestMeasurement,
         update: TestMeasurementUpdate | dict,
         update_step: bool = False,
+        log_file: str | Path | None = None,
     ) -> TestMeasurement:
         """Update a TestMeasurement.
 
         Args:
             test_measurement: The TestMeasurement or measurement ID to update.
             update: Updates to apply to the TestMeasurement.
             update_step: Whether to update the step to failed if the measurement is being updated to failed.
+            log_file: If set, log the request to this file and return a simulated response.
 
         Returns:
             The updated TestMeasurement.
         """
         ...
 
-    def update_step(self, test_step: str | TestStep, update: TestStepUpdate | dict) -> TestStep:
+    def update_step(
+        self,
+        test_step: str | TestStep,
+        update: TestStepUpdate | dict,
+        log_file: str | Path | None = None,
+    ) -> TestStep:
         """Update a TestStep.
 
         Args:
             test_step: The TestStep or test step ID to update.
             update: Updates to apply to the TestStep.
+            log_file: If set, log the request to this file and return a simulated response.
 
         Returns:
             The updated TestStep.

python/lib/sift_client/transport/grpc_transport.py

@@ -13,7 +13,7 @@
 from typing import Any
 from urllib.parse import urlparse
 
-from sift_client._internal.grpc.transport import (
+from sift_client._internal.grpc_transport.transport import (
     SiftChannelConfig,
     use_sift_async_channel,
 )