drop unused UnitCreate model

Author: wei-qlu

python/lib/sift_client/_tests/sift_types/test_unit.py

@@ -5,7 +5,7 @@
 import pytest
 from sift.unit.v2.unit_pb2 import Unit as UnitProto
 
-from sift_client.sift_types.unit import Unit, UnitCreate
+from sift_client.sift_types.unit import Unit
 
 
 @pytest.fixture
@@ -20,23 +20,6 @@ def mock_unit(mock_client):
     return unit
 
 
-class TestUnitCreate:
-    """Unit tests for UnitCreate model."""
-
-    def test_unit_create_basic(self):
-        """Test basic UnitCreate instantiation."""
-        create = UnitCreate(name="volts")
-
-        assert create.name == "volts"
-
-    def test_unit_create_to_proto(self):
-        """Test that UnitCreate converts to a CreateUnitRequest proto correctly."""
-        create = UnitCreate(name="volts")
-        proto = create.to_proto()
-
-        assert proto.name == "volts"
-
-
 class TestUnit:
     """Unit tests for Unit model - tests properties and methods."""
 

python/lib/sift_client/sift_types/__init__.py

@@ -188,7 +188,7 @@
     TestStepCreate,
     TestStepType,
 )
-from sift_client.sift_types.unit import Unit, UnitCreate
+from sift_client.sift_types.unit import Unit
 
 if "pytest" in sys.modules:
     # These are not test classes, so we need to set __test__ to False to avoid pytest warnings.
@@ -259,5 +259,4 @@
     "TestStepCreate",
     "TestStepType",
     "Unit",
-    "UnitCreate",
 ]

python/lib/sift_client/sift_types/unit.py

@@ -2,27 +2,14 @@
 
 from typing import TYPE_CHECKING
 
-from sift.unit.v2.unit_pb2 import CreateUnitRequest as CreateUnitRequestProto
 from sift.unit.v2.unit_pb2 import Unit as UnitProto
 
-from sift_client.sift_types._base import (
-    BaseType,
-    ModelCreate,
-)
+from sift_client.sift_types._base import BaseType
 
 if TYPE_CHECKING:
     from sift_client.client import SiftClient
 
 
-class UnitCreate(ModelCreate[CreateUnitRequestProto]):
-    """Create model for Unit."""
-
-    name: str
-
-    def _get_proto_class(self) -> type[CreateUnitRequestProto]:
-        return CreateUnitRequestProto
-
-
 class Unit(BaseType[UnitProto, "Unit"]):
     """Model of the Sift Unit."""