update run archive/unarchive

Author: alexluck-sift

python/lib/sift_client/_internal/low_level_wrappers/runs.py

@@ -6,7 +6,6 @@
 from sift.runs.v2.runs_pb2 import (
     CreateAutomaticRunAssociationForAssetsRequest,
     CreateRunResponse,
-    DeleteRunRequest,
     GetRunRequest,
     GetRunResponse,
     ListRunsRequest,
@@ -54,9 +53,6 @@ async def get_run(self, run_id: str) -> Run:
         Raises:
             ValueError: If run_id is not provided.
         """
-        if not run_id:
-            raise ValueError("run_id must be provided")
-
         request = GetRunRequest(run_id=run_id)
         response = await self._grpc_client.get_stub(RunServiceStub).GetRun(request)
         grpc_run = cast("GetRunResponse", response).run
@@ -135,21 +131,6 @@ async def update_run(self, update: RunUpdate) -> Run:
         updated_grpc_run = cast("UpdateRunResponse", response).run
         return Run._from_proto(updated_grpc_run)
 
-    async def archive_run(self, run_id: str) -> None:
-        """Archive a run.
-
-        Args:
-            run_id: The ID of the run to archive.
-
-        Raises:
-            ValueError: If run_id is not provided.
-        """
-        if not run_id:
-            raise ValueError("run_id must be provided")
-
-        request = DeleteRunRequest(run_id=run_id)
-        await self._grpc_client.get_stub(RunServiceStub).DeleteRun(request)
-
     async def stop_run(self, run_id: str) -> None:
         """Stop a run by setting its stop time to the current time.
 

python/lib/sift_client/resources/runs.py

@@ -147,10 +147,10 @@ async def list_(
             filter_parts.append(cel.in_("client_key", client_keys))
         if assets:
             if all(isinstance(s, str) for s in assets):
-                ids = cast("list[str]", assets)
+                ids = cast("list[str]", assets) # linting
                 filter_parts.append(cel.in_("asset_ids", ids))
             else:
-                asset = cast("list[Asset]", assets)
+                asset = cast("list[Asset]", assets)  # linting
                 filter_parts.append(cel.in_("asset_ids", [a._id_or_error for a in asset]))
         if duration_less_than:
             filter_parts.append(cel.less_than("duration_string", duration_less_than))
@@ -230,16 +230,25 @@ async def update(self, run: str | Run, update: RunUpdate | dict) -> Run:
     async def archive(
         self,
         run: str | Run,
-    ) -> None:
+    ) -> Run:
         """Archive a run.
 
         Args:
             run: The Run or run ID to archive.
         """
-        run_id = run._id_or_error if isinstance(run, Run) else run
-        await self._low_level_client.archive_run(run_id=run_id)
+        return await self.update(run, RunUpdate(is_archived=True))
+
+    async def unarchive(
+            self,
+            run: str | Run,
+    ) -> Run:
+        """Unarchive a run.
+
+        Args:
+            run: The Run or run ID to unarchive.
+        """
+        return await self.update(run, RunUpdate(is_archived=False))
 
-    # TODO: unarchive
 
     async def stop(
         self,