rm test error

Author: ian-sift

python/lib/sift_client/_tests/resources/test_test_results.py

@@ -246,8 +246,7 @@ def test_update_test_steps(self, sift_client, tmp_path):
             {"status": TestStatus.PASSED},
         )
 
-        # Compare simulated vs actual
-        assert simulated_step3.status == step3.status
+        compare_test_step_fields(simulated_step3, step3)
 
         # Update the step using class function.
         step3_1 = step3_1.update(
@@ -377,8 +376,7 @@ def test_update_test_measurements(self, sift_client, tmp_path):
             update_step=True,
         )
 
-        # Compare simulated vs actual
-        assert simulated_measurement2.passed == measurement2.passed
+        compare_test_measurement_fields(simulated_measurement2, measurement2)
 
         assert measurement2.passed == False
         assert measurement2.string_expected_value == "1.10.4"
@@ -439,8 +437,7 @@ def test_update_test_report(self, sift_client, tmp_path):
             update=TestReportUpdate(**update_kwargs),
         )
 
-        # Compare simulated vs actual for the fields that were updated
-        assert simulated_report.end_time == updated_report.end_time
+        compare_test_report_fields(simulated_report, updated_report)
 
         # Update the report using class function.
         updated_report = updated_report.update(

python/lib/sift_client/_tests/sift_types/test_results.py

@@ -148,6 +148,7 @@ def test_update_test_measurement(self, mock_test_measurement, mock_client):
                 test_measurement=mock_test_measurement,
                 update=update,
                 update_step=True,
+                log_file=None,
             )
             mock_update.assert_called_once_with(updated_measurement)
             assert result is mock_test_measurement
@@ -171,6 +172,7 @@ def test_update_test_report(self, mock_test_report, mock_client):
             mock_client.test_results.update.assert_called_once_with(
                 test_report=mock_test_report,
                 update=update,
+                log_file=None,
             )
             mock_update.assert_called_once_with(updated_report)
 

python/lib/sift_client/util/test_results/context_manager.py

@@ -118,7 +118,6 @@ def __exit__(self, exc_type, exc_value, traceback):
                 self.client.test_results.replay_log_file(self.log_file)
                 fp = os.path.abspath(self.log_file)
                 tmp_dir = tempfile.gettempdir()
-                raise Exception("test")
                 if fp.startswith(tmp_dir):
                     os.remove(fp)
             except Exception as e: