rust(bug): Create file-backup mode directories, ignore exists error (#435)

Author: tsift

Cargo.toml

@@ -13,7 +13,7 @@ members = [
 
 [workspace.package]
 authors = ["Sift Software Engineers <engineering@siftstack.com>"]
-version = "0.7.0-rc.9"
+version = "0.7.0-rc.10"
 edition = "2024"
 categories = ["aerospace", "science::robotics"]
 homepage = "https://github.com/sift-stack/sift"
@@ -27,11 +27,11 @@ chrono = { version = "0.4.39", default-features = false, features = ["clock"] }
 pbjson-types = "^0.7"
 tonic = { version = "^0.12", features = ["gzip"] }
 
-sift_connect = { version = "0.7.0-rc.9", path = "rust/crates/sift_connect" }
-sift_rs = { version = "0.7.0-rc.9", path = "rust/crates/sift_rs" }
-sift_error = { version = "0.7.0-rc.9", path = "rust/crates/sift_error" }
-sift_stream = { version = "0.7.0-rc.9", path = "rust/crates/sift_stream" }
-sift_pbfs = { version = "0.7.0-rc.9", path = "rust/crates/sift_pbfs" }
+sift_connect = { version = "0.7.0-rc.10", path = "rust/crates/sift_connect" }
+sift_rs = { version = "0.7.0-rc.10", path = "rust/crates/sift_rs" }
+sift_error = { version = "0.7.0-rc.10", path = "rust/crates/sift_error" }
+sift_stream = { version = "0.7.0-rc.10", path = "rust/crates/sift_stream" }
+sift_pbfs = { version = "0.7.0-rc.10", path = "rust/crates/sift_pbfs" }
 
 sift_stream_bindings = { version = "0.1.0", path = "rust/crates/sift_stream_bindings" }
 

rust/CHANGELOG.md

@@ -3,13 +3,22 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [v0.7.0-rc.10] - December 16, 2025
+### What's New
+#### SiftStream File-Backup Only Mode Create Parent Directories
+A minor fix to create all parent directories for file-backup only mode, as well as ignoring
+any "already exists" errors.
+
+### Full Changelog
+- [Create file-backup mode directories, ignore exists error]()
+
 ## [v0.7.0-rc.9] - December 16, 2025
 ### What's New
 #### SiftStream File-Backup Only Mode Directory Bug Fix
 A minor fix to save the backup files in the specified directory.
 
 ### Full Changelog
-- []()
+- [Fix SiftStream file-backup mode directory](https://github.com/sift-stack/sift/commit/fe041085243ca27601b327b5fd2235b6f8399d5a)
 
 ## [v0.7.0-rc.8] - December 5, 2025
 ### What's New

rust/crates/sift_stream/src/stream/builder.rs

@@ -578,12 +578,6 @@ impl SiftStreamBuilder {
             output_directory.push_str(&format!("/{}", sanitize_name(&run.name)));
         }
 
-        // Ensure the output directory exists
-        tokio::fs::create_dir_all(&output_directory)
-            .await
-            .map_err(|e| Error::new(ErrorKind::IoError, e))
-            .context("failed to create output directory")?;
-
         SiftStream::new_file_backup(
             setup_channel,
             ingestion_config,
@@ -599,6 +593,7 @@ impl SiftStreamBuilder {
             sift_stream_id,
             metrics,
         )
+        .await
     }
 }
 

rust/crates/sift_stream/src/stream/mode/file_backup.rs

@@ -19,7 +19,9 @@ use sift_rs::{
     runs::v2::Run,
 };
 use std::collections::HashSet;
+use std::io::ErrorKind as IoErrorKind;
 use std::{collections::HashMap, path::PathBuf, sync::Arc, time::Duration};
+use tokio::fs;
 use tokio::{sync::broadcast, task::JoinHandle};
 use uuid::Uuid;
 
@@ -276,7 +278,7 @@ impl SiftStream<IngestionConfigEncoder, FileBackup> {
     ///
     /// [`SiftStreamBuilder`]: crate::stream::builder::SiftStreamBuilder
     #[allow(clippy::too_many_arguments)]
-    pub(crate) fn new_file_backup(
+    pub(crate) async fn new_file_backup(
         grpc_channel: SiftChannel,
         ingestion_config: IngestionConfig,
         flows_by_name: HashMap<String, FlowDescriptor<String>>,
@@ -292,6 +294,16 @@ impl SiftStream<IngestionConfigEncoder, FileBackup> {
         metrics: Arc<SiftStreamMetrics>,
     ) -> Result<Self> {
         let full_backup_path = backups_directory.join(output_directory);
+
+        // Ensure the output directory exists
+        if let Err(err) = fs::create_dir_all(&full_backup_path).await
+            && err.kind() != IoErrorKind::AlreadyExists
+        {
+            return Err(Error::new(ErrorKind::BackupsError, err))
+                .with_context(|| format!("failed to create directory for backups at {}", full_backup_path.display()))
+                .help("if using a custom path for backups directory ensure that it's valid with proper permissions, otherwise contact Sift");
+        }
+
         let file_writer_config = FileWriterConfig {
             directory: full_backup_path,
             prefix: ingestion_config.client_key.clone(),
@@ -856,7 +868,8 @@ mod tests {
             sift_stream_id,
             metrics,
         )
-        .unwrap();
+        .await
+        .expect("failed to create file backup stream");
 
         // Finish should succeed
         stream.finish().await.unwrap();
@@ -886,7 +899,8 @@ mod tests {
             sift_stream_id,
             metrics,
         )
-        .unwrap();
+        .await
+        .expect("failed to create file backup stream");
 
         // Write some data first
         let request = create_test_request("test_flow", &ingestion_config.ingestion_config_id);