Skip to content

Commit c2d382a

Browse files
committed
protos(feature): add boolean field to toggle live rules
1 parent e94801f commit c2d382a

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

protos/sift/rules/v1/rules.proto

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,12 @@ message Rule {
351351

352352
// is_archived is inferred from when archived_date is not null
353353
bool is_archived = 21 [(google.api.field_behavior) = REQUIRED];
354+
355+
// If set to `true` then this rule will be evaluated on live data, otherwise live rule evaluation
356+
// will be disabled. This rule can still be used, however, in report generation.
357+
bool is_live_evaluation_enabled = 22 [(google.api.field_behavior) = OPTIONAL];
354358
}
359+
355360
message RuleCondition {
356361
// 4 is reserved from old "status" column that lived directly on rule condition
357362
reserved 4;
@@ -475,7 +480,13 @@ message UpdateRuleRequest {
475480
bool is_external = 12;
476481
repeated sift.metadata.v1.MetadataValue metadata = 13 [(google.api.field_behavior) = REQUIRED];
477482
bool is_archived = 14 [(google.api.field_behavior) = OPTIONAL];
483+
484+
// If set to `true` then this rule will be evaluated on live data, otherwise live rule evaluation
485+
// will be disabled. This rule can still be used, however, in report generation. If this value
486+
// is null then the original value is preserved
487+
optional bool is_live_evaluation_enabled = 15 [(google.api.field_behavior) = OPTIONAL];
478488
}
489+
479490
message UpdateConditionRequest {
480491
// 2 is reserved from old status update support on rule condition directly
481492
reserved 2;
@@ -685,7 +696,7 @@ message ListRulesRequest {
685696

686697
// A [Common Expression Language (CEL)](https://github.com/google/cel-spec) filter string.
687698
// Available fields to filter by are `rule_id`, `client_key`, `name`, `description`, `is_external`, `asset_id`, `tag_id`,
688-
// `created_date`, `created_by_user_id`, `metadata`, `modified_date`, `modified_by_user_id`, `deleted_date`, `is_archived`, and `archived_date`.
699+
// `created_date`, `created_by_user_id`, `metadata`, `modified_date`, `modified_by_user_id`, `deleted_date`, `is_archived`, `archived_date`, and `is_live_evaluation_enabled`.
689700
// For further information about how to use CELs, please refer to [this guide](https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions).
690701
// Optional.
691702
string filter = 3 [(google.api.field_behavior) = OPTIONAL];

0 commit comments

Comments
 (0)