Skip to content

Commit c8bfc4c

Browse files
authored
rust(feat): Rename ingestion_config for python linting (#555)
1 parent a4420a5 commit c8bfc4c

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

rust/crates/sift_stream_bindings/sift_stream_bindings.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ class SiftStreamBuilderPy:
539539
r"""
540540
Whether TLS is enabled. Defaults to `True`. Set to `False` for local testing only.
541541
"""
542-
ingestion_config: typing.Optional[IngestionConfigFormPy]
542+
ingestion_config_form: typing.Optional[IngestionConfigFormPy]
543543
r"""
544544
Ingestion config form. Must be set before calling [`build()`][SiftStreamBuilderPy::build].
545545
"""
@@ -567,7 +567,7 @@ class SiftStreamBuilderPy:
567567
568568
This is the quick path: `ingestion_config` must be set; all other fields are optional.
569569
For other modes (checkpointing, disk backups, tunable capacities), use
570-
[`ingestion_config()`][SiftStreamBuilderPy::ingestion_config] to advance to the full
570+
[`ingestion_config()`][SiftStreamBuilderPy::ingestion_config_form] to advance to the full
571571
builder chain.
572572
573573
Returns a coroutine that resolves to a [`SiftStreamPy`].

rust/crates/sift_stream_bindings/src/stream/builder.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ pub struct SiftStreamBuilderPy {
3838
enable_tls: bool,
3939
/// Ingestion config form. Must be set before calling [`build()`][SiftStreamBuilderPy::build].
4040
#[pyo3(get, set)]
41-
ingestion_config: Option<IngestionConfigFormPy>,
41+
ingestion_config_form: Option<IngestionConfigFormPy>,
4242
/// Optional run to associate with the stream. Mutually exclusive with `run_id`;
4343
/// if both are set, `run_id` takes precedence.
4444
#[pyo3(get, set)]
@@ -64,7 +64,7 @@ impl SiftStreamBuilderPy {
6464
uri: uri.into(),
6565
apikey: apikey.into(),
6666
enable_tls: true,
67-
ingestion_config: None,
67+
ingestion_config_form: None,
6868
run: None,
6969
run_id: None,
7070
asset_tags: None,
@@ -76,12 +76,12 @@ impl SiftStreamBuilderPy {
7676
///
7777
/// This is the quick path: `ingestion_config` must be set; all other fields are optional.
7878
/// For other modes (checkpointing, disk backups, tunable capacities), use
79-
/// [`ingestion_config()`][SiftStreamBuilderPy::ingestion_config] to advance to the full
79+
/// [`ingestion_config()`][SiftStreamBuilderPy::ingestion_config_form] to advance to the full
8080
/// builder chain.
8181
///
8282
/// Returns a coroutine that resolves to a [`SiftStreamPy`].
8383
pub fn build(&mut self, py: Python) -> PyResult<Py<PyAny>> {
84-
let ingestion_config = self.ingestion_config.clone().ok_or_else(|| {
84+
let ingestion_config = self.ingestion_config_form.clone().ok_or_else(|| {
8585
pyo3::exceptions::PyValueError::new_err(
8686
"ingestion_config must be set before calling build()",
8787
)

0 commit comments

Comments
 (0)