Fix unit tests

Author: marc-sift

python/lib/sift_py/rule/_service_test.py

@@ -116,7 +116,7 @@ def test_rule_service_load_rules_from_yaml(rule_service):
             assert rule_config.expression == rule_yaml["expression"]
             assert rule_config.action.assignee == rule_yaml["assignee"]
             assert rule_config.asset_names == rule_yaml["asset_names"]
-            assert rule_config.tag_names == rule_yaml["tag1"]
+            assert rule_config.tag_names == rule_yaml["tag_names"]
             assert isinstance(rule_config.action, RuleActionCreateDataReviewAnnotation)
 
 

python/lib/sift_py/rule/service.py

@@ -415,8 +415,7 @@ def _update_req_from_rule_config(
             else None
         )
         annotation_tags = (
-            list_tags_impl(
-                self._tag_service_stub,
+            self._get_tags(
                 names=[tag for tag in config.action.tags],
                 tag_type=TagType.TAG_TYPE_ANNOTATION,
             )

python/lib/sift_py/tag/_internal/shared.py

@@ -59,9 +59,5 @@ def get_tags_with_filter(
     if ids:
         ids_cel = cel_in("tag_id", ids)
         results.extend(get_tags_with_filter(tag_service_stub, ids_cel, tag_type))
-    if not names and not ids:
-        # If no filter, but tag_type is specified, fetch all tags of that type
-        if tag_type is not None:
-            results.extend(get_tags_with_filter(tag_service_stub, "", tag_type))
 
     return results