Skip to content

python(feat): Try using faster yaml loader with fallback for older py…#322

Merged
ian-sift merged 3 commits into
mainfrom
eng-5717-client-library-change-yaml-loader
Sep 23, 2025
Merged

python(feat): Try using faster yaml loader with fallback for older py…#322
ian-sift merged 3 commits into
mainfrom
eng-5717-client-library-change-yaml-loader

Conversation

@ian-sift
Copy link
Copy Markdown
Contributor

Python3.13.5

Before

$ python3 ./examples/ingestion_with_yaml_config/main.py                                                                                                                                [13:54:42]
Telemetry config load time: 0.0021049976348876953 seconds
Rule load time: 4.1961669921875e-05 seconds

After

/$ python3 ./examples/ingestion_with_yaml_config/main.py                                                                                                                                [14:19:49]
Telemetry config load time: 0.0004990100860595703 seconds
Rule load time: 3.790855407714844e-05 seconds

Python3.8

Before

Telemetry config load time: 0.003070831298828125 seconds
Rule load time: 4.124641418457031e-05 seconds
(venv3.8)  

After

ian@Mac: ~/code/sift/python eng-5717-client-library-change-yaml-loader ⚡
$ python3 ./examples/ingestion_with_yaml_config/main.py                                                                                                                                [14:11:03]
Telemetry config load time: 0.002889871597290039 seconds
Rule load time: 3.6716461181640625e-05 seconds

@ian-sift ian-sift requested a review from marc-sift September 17, 2025 21:26
Comment thread python/lib/sift_py/yaml/utils.py Outdated
Copy link
Copy Markdown
Contributor

@marc-sift marc-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small comment.

alexluck-sift
alexluck-sift previously approved these changes Sep 23, 2025
Comment thread python/examples/ingestion_with_yaml_config/main.py
@ian-sift ian-sift dismissed marc-sift’s stale review September 23, 2025 16:58

marc ooo. alex stepping in

@ian-sift ian-sift merged commit 6d80c67 into main Sep 23, 2025
10 checks passed
@ian-sift ian-sift deleted the eng-5717-client-library-change-yaml-loader branch September 23, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants