python(feat): add TDMS client-side detect_config#538
Merged
Conversation
2008319 to
e4ece74
Compare
marc-sift
requested changes
Apr 17, 2026
marc-sift
reviewed
Apr 17, 2026
marc-sift
reviewed
Apr 17, 2026
marc-sift
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Implement TDMS
detect_configclient-side and update TDMS data import models to reflect proto changes.Detection handles waveform channels, dedicated time channels (TimeStamp type,
xchannelproperty, common names), complex-valued channel splitting, enum detection, and fallback behavior for channels missing timing info, matching the existing backend implementation.Model updates: added
TdmsFallbackMethod,TdmsComplexComponentenums,TdmsDataColumntype, and expandedTdmsImportConfigwith new proto fields plus_to_proto/_from_protosupport.Verification
Unit tests and manual testing with a local script, verifying the full import process succeeded:
Example import workflow