rust(bug): Fix recursive/nested hdf5 imports#579
Open
Brandon-Shippy wants to merge 17 commits into
Open
Conversation
solidiquis
requested changes
May 20, 2026
added 12 commits
May 20, 2026 11:31
added 2 commits
May 20, 2026 16:56
…s under sift groups
tsift
approved these changes
May 21, 2026
|
|
||
| if group_time.is_empty() { | ||
| return Err(anyhow!( | ||
| "no time dataset found — expected one of {TIME_NAMES:?} (case-insensitive) \ |
Contributor
There was a problem hiding this comment.
General question, how fixed are the possible time names? Wondering if longer term it could be useful to make these definable through the CLI?
| assert_eq!(mapped.len(), 2); | ||
| assert_eq!(mapped[0].name, "OFF"); | ||
| assert_eq!(mapped[0].key, 0); | ||
| assert!(mapped[0].is_signed); |
Contributor
There was a problem hiding this comment.
Should there be a test for an unsigned enum?
solidiquis
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verification
1d2dcompoundand properly structures in sift